98ff3abd09
This patch is the same approach as the one that want into 2.2.x. It
covers the functions in 2.3.x that do not exist in 2.2.x.
Without this patch all of the spec tests for parser functions in stdlib
would instantiate their own scope instances. This is a problem because
the standard library is tightly coupled with the internal behavior of
Puppet. Tight coupling like this creates failures when we change the
internal behavior of Puppet. This is exactly what happened recently
when we changed the method signature for the initializer of
Puppet::Parser::Scope instances.
This patch fixes the problem by creating scope instances using the
puppet labs spec helper. The specific method that provides scope
instances in Puppet-version-independent way is something like this:
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
This patch simply implements this across the board.
79 lines
2.2 KiB
Ruby
79 lines
2.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Puppet::Parser::Functions.function(:validate_absolute_path) do
|
|
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
|
|
|
|
# The subject of these examplres is the method itself.
|
|
subject() { scope.method(:function_validate_absolute_path) }
|
|
|
|
describe "Valid Paths" do
|
|
def self.valid_paths
|
|
%w{
|
|
C:/
|
|
C:\\
|
|
C:\\WINDOWS\\System32
|
|
C:/windows/system32
|
|
X:/foo/bar
|
|
X:\\foo\\bar
|
|
/var/tmp
|
|
/var/lib/puppet
|
|
/var/opt/../lib/puppet
|
|
}
|
|
end
|
|
|
|
context "Without Puppet::Util.absolute_path? (e.g. Puppet <= 2.6)" do
|
|
before :each do
|
|
# The intent here is to mock Puppet to behave like Puppet 2.6 does.
|
|
# Puppet 2.6 does not have the absolute_path? method. This is only a
|
|
# convenience test, stdlib should be run with the Puppet 2.6.x in the
|
|
# $LOAD_PATH in addition to 2.7.x and master.
|
|
Puppet::Util.expects(:respond_to?).with(:absolute_path?).returns(false)
|
|
end
|
|
valid_paths.each do |path|
|
|
it "validate_absolute_path(#{path.inspect}) should not fail" do
|
|
expect { subject.call [path] }.not_to raise_error Puppet::ParseError
|
|
end
|
|
end
|
|
end
|
|
|
|
context "Puppet without mocking" do
|
|
valid_paths.each do |path|
|
|
it "validate_absolute_path(#{path.inspect}) should not fail" do
|
|
expect { subject.call [path] }.not_to raise_error Puppet::ParseError
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'Invalid paths' do
|
|
context 'Garbage inputs' do
|
|
[
|
|
nil,
|
|
[ nil ],
|
|
{ 'foo' => 'bar' },
|
|
{ },
|
|
'',
|
|
].each do |path|
|
|
it "validate_absolute_path(#{path.inspect}) should fail" do
|
|
expect { subject.call [path] }.to raise_error Puppet::ParseError
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'Relative paths' do
|
|
%w{
|
|
relative1
|
|
.
|
|
..
|
|
./foo
|
|
../foo
|
|
etc/puppetlabs/puppet
|
|
opt/puppet/bin
|
|
}.each do |path|
|
|
it "validate_absolute_path(#{path.inspect}) should fail" do
|
|
expect { subject.call [path] }.to raise_error Puppet::ParseError
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|