8a4e115ccb
Without this patch all of the spec tests for parser functions in stdlib
would instantiate their own scope instances. This is a problem because
the standard library is tightly coupled with the internal behavior of
Puppet. Tight coupling like this creates failures when we change the
internal behavior of Puppet. This is exactly what happened recently
when we changed the method signature for the initializer of
Puppet::Parser::Scope instances.
This patch fixes the problem by creating scope instances using the
puppet labs spec helper. The specific method that provides scope
instances in Puppet-version-independent way is something like this:
let(:scope) { PuppetlabsSpec::PuppetSeams.parser_scope }
This patch simply implements this across the board.
51 lines
1.7 KiB
Ruby
51 lines
1.7 KiB
Ruby
#! /usr/bin/env/ruby -S rspec
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Puppet::Parser::Functions.function(:validate_bool) do
|
|
let(:scope) { PuppetlabsSpec::PuppetSeams.parser_scope }
|
|
describe 'when calling validate_bool from puppet' do
|
|
|
|
%w{ true false }.each do |the_string|
|
|
|
|
it "should not compile when #{the_string} is a string" do
|
|
Puppet[:code] = "validate_bool('#{the_string}')"
|
|
expect { scope.compiler.compile }.should raise_error(Puppet::ParseError, /is not a boolean/)
|
|
end
|
|
|
|
it "should compile when #{the_string} is a bare word" do
|
|
Puppet[:code] = "validate_bool(#{the_string})"
|
|
scope.compiler.compile
|
|
end
|
|
|
|
end
|
|
|
|
it "should not compile when an arbitrary string is passed" do
|
|
Puppet[:code] = 'validate_bool("jeff and dan are awesome")'
|
|
expect { scope.compiler.compile }.should raise_error(Puppet::ParseError, /is not a boolean/)
|
|
end
|
|
|
|
it "should not compile when no arguments are passed" do
|
|
Puppet[:code] = 'validate_bool()'
|
|
expect { scope.compiler.compile }.should raise_error(Puppet::ParseError, /wrong number of arguments/)
|
|
end
|
|
|
|
it "should compile when multiple boolean arguments are passed" do
|
|
Puppet[:code] = <<-'ENDofPUPPETcode'
|
|
$foo = true
|
|
$bar = false
|
|
validate_bool($foo, $bar, true, false)
|
|
ENDofPUPPETcode
|
|
scope.compiler.compile
|
|
end
|
|
|
|
it "should compile when multiple boolean arguments are passed" do
|
|
Puppet[:code] = <<-'ENDofPUPPETcode'
|
|
$foo = true
|
|
$bar = false
|
|
validate_bool($foo, $bar, true, false, 'jeff')
|
|
ENDofPUPPETcode
|
|
expect { scope.compiler.compile }.should raise_error(Puppet::ParseError, /is not a boolean/)
|
|
end
|
|
end
|
|
end
|