98ff3abd09
This patch is the same approach as the one that want into 2.2.x. It
covers the functions in 2.3.x that do not exist in 2.2.x.
Without this patch all of the spec tests for parser functions in stdlib
would instantiate their own scope instances. This is a problem because
the standard library is tightly coupled with the internal behavior of
Puppet. Tight coupling like this creates failures when we change the
internal behavior of Puppet. This is exactly what happened recently
when we changed the method signature for the initializer of
Puppet::Parser::Scope instances.
This patch fixes the problem by creating scope instances using the
puppet labs spec helper. The specific method that provides scope
instances in Puppet-version-independent way is something like this:
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
This patch simply implements this across the board.
48 lines
2.2 KiB
Ruby
Executable file
48 lines
2.2 KiB
Ruby
Executable file
#! /usr/bin/env ruby -S rspec
|
|
|
|
require 'spec_helper'
|
|
|
|
describe "the validate_slength function" do
|
|
let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
|
|
|
|
it "should exist" do
|
|
Puppet::Parser::Functions.function("validate_slength").should == "function_validate_slength"
|
|
end
|
|
|
|
it "should raise a ParseError if there is less than 2 arguments" do
|
|
expect { scope.function_validate_slength([]) }.to(raise_error(Puppet::ParseError))
|
|
expect { scope.function_validate_slength(["asdf"]) }.to(raise_error(Puppet::ParseError))
|
|
end
|
|
|
|
it "should raise a ParseError if argument 2 doesn't convert to a fixnum" do
|
|
expect { scope.function_validate_slength(["moo",["2"]]) }.to(raise_error(Puppet::ParseError, /Couldn't convert whatever you passed/))
|
|
end
|
|
|
|
it "should raise a ParseError if argument 2 converted, but to 0, e.g. a string" do
|
|
expect { scope.function_validate_slength(["moo","monkey"]) }.to(raise_error(Puppet::ParseError, /please pass a positive number as max_length/))
|
|
end
|
|
|
|
it "should raise a ParseError if argument 2 converted, but to 0" do
|
|
expect { scope.function_validate_slength(["moo","0"]) }.to(raise_error(Puppet::ParseError, /please pass a positive number as max_length/))
|
|
end
|
|
|
|
it "should fail if string greater then size" do
|
|
expect { scope.function_validate_slength(["test", 2]) }.to(raise_error(Puppet::ParseError, /It should have been less than or equal to/))
|
|
end
|
|
|
|
it "should fail if you pass an array of something other than strings" do
|
|
expect { scope.function_validate_slength([["moo",["moo"],Hash.new["moo" => 7]], 7]) }.to(raise_error(Puppet::ParseError, /is not a string, it's a/))
|
|
end
|
|
|
|
it "should fail if you pass something other than a string or array" do
|
|
expect { scope.function_validate_slength([Hash.new["moo" => "7"],6]) }.to(raise_error(Puppet::ParseError), /please pass a string, or an array of strings/)
|
|
end
|
|
|
|
it "should not fail if string is smaller or equal to size" do
|
|
expect { scope.function_validate_slength(["test", 5]) }.to_not(raise_error(Puppet::ParseError))
|
|
end
|
|
|
|
it "should not fail if array of string is are all smaller or equal to size" do
|
|
expect { scope.function_validate_slength([["moo","foo","bar"], 5]) }.to_not(raise_error(Puppet::ParseError))
|
|
end
|
|
end
|