From 04359c9184fb349ded30b934eb28dbe157a1041b Mon Sep 17 00:00:00 2001 From: lilia Date: Sun, 20 Dec 2015 23:32:39 -0800 Subject: [PATCH] Remove received_at from message detail on outgoing messages Only show sent_at for outgoing messages, matching Android. The received_at timestamp reflects the time a message was saved locally. It is necessary on both incoming and outgoing messages for sorting purposes, but can be confusing in the context of an outgoing message detail view, since users don't think about themselves "receiving" their own messages, and may even interpret this as the time that a message was received by their conversation partner's device. // FREEBIE --- background.html | 4 +++- js/views/message_detail_view.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/background.html b/background.html index 1b177c9f..497b10a1 100644 --- a/background.html +++ b/background.html @@ -176,7 +176,9 @@ {{ /hasRetry }} - + {{ #received_at }} + + {{ /received_at }} {{ #errors }} diff --git a/js/views/message_detail_view.js b/js/views/message_detail_view.js index d910c6d4..d77cd854 100644 --- a/js/views/message_detail_view.js +++ b/js/views/message_detail_view.js @@ -109,7 +109,7 @@ }); this.$el.html(Mustache.render(_.result(this, 'template', ''), { sent_at : moment(this.model.get('sent_at')).toString(), - received_at : moment(this.model.get('received_at')).toString(), + received_at : this.model.isIncoming() ? moment(this.model.get('received_at')).toString() : null, tofrom : this.model.isIncoming() ? 'From' : 'To', errors : this.errors['undefined'], hasRetry : hasRetry
Sent {{ sent_at }}
Received {{ received_at }}
Received {{ received_at }}
Error