From 1f2dfc5ea98b1b75eda90cbe4bf0cf436b4626ab Mon Sep 17 00:00:00 2001 From: lilia Date: Wed, 10 Feb 2016 11:21:39 -0800 Subject: [PATCH] Only update notification on add Previously, notifications were persistent until explicitly dismissed from the notification center (a bell icon in the system tray), but that ui has been removed from chrome*, so now updating on remove is unexpectedly creating a new notification pop up. *http://blog.chromium.org/2015/10/streamlining-notifications-on-desktop.html Fixes #667 // FREEBIE --- js/notifications.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/js/notifications.js b/js/notifications.js index f81e95f2..119b5653 100644 --- a/js/notifications.js +++ b/js/notifications.js @@ -8,7 +8,6 @@ Whisper.Notifications = new (Backbone.Collection.extend({ initialize: function() { this.on('add', this.onAdd); - this.on('remove', this.onRemove); }, isEnabled: function(callback) { return Notification.permission === 'granted' && @@ -83,9 +82,6 @@ extension.notification.clear(); this.update(); }, - onRemove: function() { - this.update(); - }, clear: function() { this.reset([]); }