diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 1c5e65b7..881de275 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,30 +1,31 @@ - -Delete any sections that aren't relevant. ---> - - - [ ] I have searched open and closed issues for duplicates +---------------------------------------- ### Bug description - +Describe here the issue that you are experiencing. ### Steps to reproduce -- add your steps here -- as a list -- using hyphens +- using hyphens as bullet points +- list the steps +- that reproduce the bug + +**Actual result:** Describe here what happens after you run the steps above (i.e. the buggy behaviour) +**Expected result:** Describe here what should happen after you run the steps above (i.e. what would be the correct behaviour) ### Screenshots - + ### Platform info @@ -34,3 +35,4 @@ Delete any sections that aren't relevant. **Signal version:** Z.Y.Y ### Link to debug log + diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0e05c831..db860c39 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,20 +1,28 @@ - + ### First time contributor checklist - -- [ ] I have read the [Contributor Guidelines](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md) + +- [ ] I have read the [README](https://github.com/WhisperSystems/Signal-Desktop/blob/master/README.md) and [Contributor Guidelines](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md) - [ ] I have signed the [Contributor Licence Agreement](https://whispersystems.org/cla/) ### Contributor checklist - + +- [ ] My contribution is fully baked and ready to be merged as is - [ ] My changes are rebased on the latest master branch -- [ ] My contribution is fully baked and is ready to be merged as is -- [ ] I have run the tests on these platforms: +- [ ] My commits are in nice logical chunks +- [ ] I have followed the [best practices](http://chris.beams.io/posts/git-commit/) in my commit messages +- [ ] I have made the choice whether I want the [BitHub reward](https://github.com/WhisperSystems/Signal-Android/wiki/BitHub-Rewards) or not by omitting or adding the word `FREEBIE` in my Git commit messages +- [ ] I have tested my contribution on these platforms: * GNU Hurd 1.0, Chrom{e,ium} X.Y.Z * Amiga OS 3.1, Chrom{e,ium} Z.Y -- [ ] My commits are in nice logical chunks -- [ ] I followed the [best practices](http://chris.beams.io/posts/git-commit/) when writing my commit messages -- [ ] I have made the choice whether I want the Bithub reward or not by omitting or adding the word `FREEBIE` in my commit message +- [ ] My changes pass all the [local tests](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md#tests) 100% +- [ ] I have considered whether my changes need additional [tests](https://github.com/WhisperSystems/Signal-Desktop/blob/master/CONTRIBUTING.md#tests), and in the case they do, I have written them ----------- +---------------------------------------- ### Description +