thegamer/Cable-Desktop
2
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't load group contacts unnecessarily

Browse source 
There are some cases when we want to initialize a group object without
loading its contacts, such as while processing delivery receipts. We
really only need to load the contacts for a group/convo when we are
rendering it, so let the front end handle those cases (which most of
them do already).
This commit is contained in:
lilia 2016-11-16 12:36:50 +01:00
parent ae6174c511
commit 6699571910
2 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
js/models/conversations.js
View file

@ -41,13 +41,12 @@
this.on('change:avatar', this.updateAvatarUrl);
this.on('destroy', this.revokeAvatarUrl);
this.on('read', this.onReadMessage);
this.fetchContacts().then(function() {
this.contactCollection.each(function(contact) {
textsecure.storage.protocol.on('keychange:' + contact.id, function() {
this.addKeyChange(contact.id);
}.bind(this));
var members = this.get('members') || [];
members.map(function(number) {
textsecure.storage.protocol.on('keychange:' + m.id, function() {
this.conversation.addKeyChange(m.id);
}.bind(this));
}.bind(this));
});
},
addKeyChange: function(id) {
@ -324,7 +323,7 @@
} else {
var promises = [];
var members = this.get('members') || [];
this.contactCollection.reset(
this.contactCollection.add(
members.map(function(number) {
var c = ConversationController.create({
id : number,

12
js/views/conversation_view.js
View file

@ -269,12 +269,14 @@
},
messageDetail: function(e, data) {
var view = new Whisper.MessageDetailView({
model: data.message,
conversation: this.model
return this.model.fetchContacts().then(function() {
var view = new Whisper.MessageDetailView({
model: data.message,
conversation: this.model
});
this.listenBack(view);
view.render();
});
this.listenBack(view);
view.render();
},
listenBack: function(view) {