thegamer/Cable-Desktop
2
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix click handler

Browse source 
var i was being bound in the closure of this click handler, then
incremented by the for loop, such that its value was 1 by the time the
handler was called, so we were grabbing the message body from, e.g.
$("#input1") when we wanted $("#input0").
This commit is contained in:
lilia 2014-04-08 22:52:56 -07:00
parent 2630d9ef3f
commit 68027dadd4
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
js/popup.js
View file

@ -33,26 +33,27 @@ registerOnLoadFunction(function() {
var messages = $('<ul class="conversation">');
for (var j = 0; j < MAX_MESSAGES_PER_CONVERSATION && j < conversation.length; j++) {
var message = conversation[j];
$('<li class="message incoming">').
$('<li class="message incoming container">').
append($('<div class="avatar">')).
append($('<div class="bubble">').
append($('<span class="message-text">').text(message.message)).
append($('<span class="metadata">').text("From: " + message.sender + ", at: " + timestampToHumanReadable(message.timestamp)))
).appendTo(messages);
}
var button = $('<button id="button' + i + '">').text('Send');
var input = $('<input id="text' + i + '">');
$('<li>').
append(messages).
append($("<form class='container'>").
append("<input type='text' id=text" + i + " /><button id=button" + i + ">Send</button><br>")
).appendTo(ul);
$('#button' + i).click(function() {
append($("<form class='container'>").append(input).append(button)).
appendTo(ul);
button.click(function() {
var sendDestinations = [conversation[0].sender];
if (conversation[0].group) {
sendDestinations = conversation[0].group.members;
}
var messageProto = new PushMessageContentProtobuf();
messageProto.body = $('#text' + i).val();
messageProto.body = input.val();
sendMessageToNumbers(sendDestinations, messageProto, function(result) {
console.log("Sent message: " + result);