From ce4ce164af07fc32ae8101b4f2e87bbdc3a5c56c Mon Sep 17 00:00:00 2001
From: lilia <liliakai@gmail.com>
Date: Sat, 31 Jan 2015 03:57:01 -1000
Subject: [PATCH] Stop clobbering conversation attributes

Unless the background page fetches the latest details of a conversation
before updating it, it may clobber or nullify some attributes e.g., the
contact's name.
---
 js/background.js | 68 +++++++++++++++++++++++++-----------------------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/js/background.js b/js/background.js
index 904e7a9e..4b32093f 100644
--- a/js/background.js
+++ b/js/background.js
@@ -93,42 +93,44 @@
             type : 'private'
         }, { merge : true } );
 
-        var message = messages.add({
-            source         : pushMessage.source,
-            sourceDevice   : pushMessage.sourceDevice,
-            relay          : pushMessage.relay,
-            sent_at        : timestamp,
-            received_at    : now,
-            conversationId : pushMessage.source,
-            type           : 'incoming'
-        });
+        conversation.fetch().always(function() {
+            var message = messages.add({
+                source         : pushMessage.source,
+                sourceDevice   : pushMessage.sourceDevice,
+                relay          : pushMessage.relay,
+                sent_at        : timestamp,
+                received_at    : now,
+                conversationId : pushMessage.source,
+                type           : 'incoming'
+            });
 
-        var newUnreadCount = textsecure.storage.getUnencrypted("unreadCount", 0) + 1;
-        textsecure.storage.putUnencrypted("unreadCount", newUnreadCount);
-        extension.navigator.setBadgeText(newUnreadCount);
+            var newUnreadCount = textsecure.storage.getUnencrypted("unreadCount", 0) + 1;
+            textsecure.storage.putUnencrypted("unreadCount", newUnreadCount);
+            extension.navigator.setBadgeText(newUnreadCount);
 
-        conversation.save().then(function() {
-            message.save().then(function() {
-                return new Promise(function(resolve) {
-                    resolve(textsecure.protocol.handleIncomingPushMessageProto(pushMessage).then(
-                        function(pushMessageContent) {
-                            handlePushMessageContent(pushMessageContent, message);
+            conversation.save().then(function() {
+                message.save().then(function() {
+                    return new Promise(function(resolve) {
+                        resolve(textsecure.protocol.handleIncomingPushMessageProto(pushMessage).then(
+                            function(pushMessageContent) {
+                                handlePushMessageContent(pushMessageContent, message);
+                            }
+                        ));
+                    }).catch(function(e) {
+                        if (e.name === 'IncomingIdentityKeyError') {
+                            e.args.push(message.id);
+                            message.save({ errors : [e] }).then(function() {
+                                extension.trigger('message', message); // notify frontend listeners
+                            });
+                        } else if (e.message === 'Bad MAC') {
+                            message.save({ errors : [ _.pick(e, ['name', 'message'])]}).then(function() {
+                                extension.trigger('message', message); // notify frontend listeners
+                            });
+                        } else {
+                            console.log(e);
+                            throw e;
                         }
-                    ));
-                }).catch(function(e) {
-                    if (e.name === 'IncomingIdentityKeyError') {
-                        e.args.push(message.id);
-                        message.save({ errors : [e] }).then(function() {
-                            extension.trigger('message', message); // notify frontend listeners
-                        });
-                    } else if (e.message === 'Bad MAC') {
-                        message.save({ errors : [ _.pick(e, ['name', 'message'])]}).then(function() {
-                            extension.trigger('message', message); // notify frontend listeners
-                        });
-                    } else {
-                        console.log(e);
-                        throw e;
-                    }
+                    });
                 });
             });
         });