From 68027dadd4b4e1c99f5a20647cceff62f6fcfec8 Mon Sep 17 00:00:00 2001
From: lilia <liliakai@gmail.com>
Date: Tue, 8 Apr 2014 22:52:56 -0700
Subject: [PATCH] Fix click handler

var i was being bound in the closure of this click handler, then
incremented by the for loop, such that its value was 1 by the time the
handler was called, so we were grabbing the message body from, e.g.
$("#input1") when we wanted $("#input0").
---
 js/popup.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/js/popup.js b/js/popup.js
index 5bffab92..8acff949 100644
--- a/js/popup.js
+++ b/js/popup.js
@@ -33,26 +33,27 @@ registerOnLoadFunction(function() {
 				var messages = $('<ul class="conversation">');
 				for (var j = 0; j < MAX_MESSAGES_PER_CONVERSATION && j < conversation.length; j++) {
 					var message = conversation[j];
-					$('<li class="message incoming">').
+					$('<li class="message incoming container">').
 						append($('<div class="avatar">')).
 						append($('<div class="bubble">').
 							append($('<span class="message-text">').text(message.message)).
 							append($('<span class="metadata">').text("From: " + message.sender + ", at: " + timestampToHumanReadable(message.timestamp)))
 						).appendTo(messages);
 				}
+				var button = $('<button id="button' + i + '">').text('Send');
+				var input = $('<input id="text' + i + '">');
 				$('<li>').
 					append(messages).
-					append($("<form class='container'>").
-						append("<input type='text' id=text" + i + " /><button id=button" + i + ">Send</button><br>")
-					).appendTo(ul);
-				$('#button' + i).click(function() {
+					append($("<form class='container'>").append(input).append(button)).
+					appendTo(ul);
+				button.click(function() {
 					var sendDestinations = [conversation[0].sender];
 					if (conversation[0].group) {
 							sendDestinations = conversation[0].group.members;
 					}
 
 					var messageProto = new PushMessageContentProtobuf();
-					messageProto.body = $('#text' + i).val();
+					messageProto.body = input.val();
 
 					sendMessageToNumbers(sendDestinations, messageProto, function(result) {
 						console.log("Sent message: " + result);