thegamer/Cable-Desktop
2
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't surface invalid attachment urls to the user

Browse source 
Log them, but don't put display them in user-facing error ui.

// FREEBIE
This commit is contained in:
lilia 2015-12-07 16:52:45 -08:00
parent 7b1268e5f7
commit ea980b4385
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
js/libtextsecure.js
View file

@ -36498,7 +36498,8 @@ var TextSecureServer = (function() {
}).then(function(response) {
var match = response.location.match(this.attachment_id_regex);
if (!match) {
throw new Error('Received invalid attachment url: ' + response.location);
console.log('Invalid attachment url for incoming message', response.location);
throw new Error('Received invalid attachment url');
}
return ajax(response.location, {
type : "GET",
@ -36516,7 +36517,8 @@ var TextSecureServer = (function() {
// (workaround for ids too large for Javascript numbers)
var match = response.location.match(this.attachment_id_regex);
if (!match) {
throw new Error('Received invalid attachment url: ' + response.location);
console.log('Invalid attachment url for outgoing message', response.location);
throw new Error('Received invalid attachment url');
}
return ajax(response.location, {
type : "PUT",

6
libtextsecure/api.js
View file

@ -315,7 +315,8 @@ var TextSecureServer = (function() {
}).then(function(response) {
var match = response.location.match(this.attachment_id_regex);
if (!match) {
throw new Error('Received invalid attachment url: ' + response.location);
console.log('Invalid attachment url for incoming message', response.location);
throw new Error('Received invalid attachment url');
}
return ajax(response.location, {
type : "GET",
@ -333,7 +334,8 @@ var TextSecureServer = (function() {
// (workaround for ids too large for Javascript numbers)
var match = response.location.match(this.attachment_id_regex);
if (!match) {
throw new Error('Received invalid attachment url: ' + response.location);
console.log('Invalid attachment url for outgoing message', response.location);
throw new Error('Received invalid attachment url');
}
return ajax(response.location, {
type : "PUT",