Commit graph

726 commits

Author SHA1 Message Date
Chris Boot
42ab470d00 apt_key: fix parsing invalid dates when using GnuPG 2.x
If one should happen to have redirected /usr/bin/gpg to run GnuPG 2.x
rather than the more usual GnuPG 1.x, the apt_key provider fails with
the following error:

Could not prefetch apt_key provider 'apt_key': invalid date

This is because the output of "--with-colons" defaults to using
"fixed-list-mode" in 2.x but did not do so for 1.x. This new format
gives much more information about keys and also uses timestamps in
seconds from 1970-01-01 (UNIX epoch) rather than dates in the format
YYYY-MM-DD.

This patch adds "--fixed-list-mode" when calling apt-key, and adjusts
the code to parse the timestamps instead. This actually has several
advantages:

- Works the same with GnuPG 1.x and 2.x.
- More accurate expiry time tracking, not just entire days.
- No need to require 'date' any longer.
- Will allow the provider to expose more key information in future.

Tested on:
- Debian Wheezy (Puppet 2.7.23, Ruby 1.8.7p358)
- Debian Jessie (Puppet 3.7.2, Ruby 2.1.5p273)
2015-03-15 22:33:22 +00:00
Colleen Murphy
7c48eb2f0e Merge pull request #464 from mhaskel/README_cleanup
Update docs for unattended_upgrades
2015-03-13 15:33:12 -07:00
Morgan Haskel
399d3cae5a Update docs and test for $legacy_origin 2015-03-13 15:31:38 -07:00
Hunter Haugen
dbd1b0decb Merge pull request #463 from mhaskel/toggle-legacy-origin
Allow changing legacy_origin
2015-03-13 15:29:20 -07:00
Morgan Haskel
81bb96c898 Update docs and test for $legacy_origin 2015-03-13 14:56:53 -07:00
Mikko Pesari
3799e3a23c unattended_upgrades: Allow changing legacy_origin
This enables using Origins-Pattern in Ubuntu.
2015-03-13 14:50:16 -07:00
Morgan Haskel
97f70034c9 Merge pull request #459 from tphoney/modules-1675_check_gpg_version
initial commit for apt_key checking
2015-03-13 14:40:43 -07:00
Morgan Haskel
0f81525367 Merge pull request #456 from johanfleury/cleaning/template/unattended-upgrades
Cleaning 50unattended-upgrades.erb
2015-03-13 14:10:13 -07:00
Colleen Murphy
b67b91b53f Merge pull request #462 from mhaskel/optional_software_properties
Make installation of software-properties optional
2015-03-13 13:51:56 -07:00
Morgan Haskel
0c35704245 Make installation of software-properties optional
This is cherry-picked from the PPA cleanup happening for the 2.0.0 release.

Conflicts:
	manifests/params.pp
	manifests/ppa.pp
2015-03-13 13:38:38 -07:00
tphoney
f588f2651a initial commit for gpg key checking
better attempt at gpg version checking

adding in key length warning

removing version check, adding key check

adding tests

clean up the code

small changes

use commands

documentation updates
2015-03-12 18:25:26 +00:00
Johan Fleury
31f732e789 Cleaning 50unattended-upgrades.erb 2015-03-09 00:01:57 +01:00
TP Honey
b473af1ec5 Merge pull request #454 from LeslieCarr/MODULES-1827-add-cumulus-linux
MODULES-1827 adding Cumulus Linux detection
2015-03-06 12:13:49 +00:00
Leslie Carr
4802a6fc77 MODULES-1827 adding Cumulus Linux detection
the apt module did not correctly detect Cumulus Linux with lsbdistid.
This change adds several lines in params.pp to detect Cumulus Linux and
set $distid and $distcodename
2015-03-05 16:56:03 -08:00
Daniele Sluijters
0e3220711b Merge pull request #437 from fraenki/fix_example
fix hiera example in documentation
2015-02-24 14:48:20 +01:00
Frank Wall
08192b3927 fix hiera example in documentation 2015-02-24 14:38:43 +01:00
Morgan Haskel
d50dd2ed3a Merge pull request #425 from nibalizer/master
Remove travis badge
2015-02-19 13:57:41 -08:00
Spencer Krum
794740813d Remove travis badge 2015-02-19 13:55:24 -08:00
Daniele Sluijters
da4a1dcecf Merge pull request #422 from cmurphy/lint
Ensure linter fails on lint warnings
2015-02-13 09:23:53 +01:00
Daniele Sluijters
6166de1f4a Merge pull request #421 from cmurphy/future
Update spec tests for future parser
2015-02-13 09:23:41 +01:00
Colleen Murphy
4d39089ac2 Ensure linter fails on lint warnings 2015-02-12 12:24:56 -08:00
Colleen Murphy
e05810d032 Update spec tests for future parser
Strings must be quoted in the future parser.
2015-02-12 12:24:02 -08:00
Daniele Sluijters
83ae566b08 Merge pull request #389 from stdietrich/global_header_partial
(MODULES-1200) Fix inconsistent header across files
2015-02-06 22:10:41 +01:00
Stefan Dietrich
443db5a7c2 (MODULES-1200) Fix inconsistent header across files 2015-02-06 21:16:05 +01:00
Daniele Sluijters
bf9b187405 Merge pull request #416 from mkrakowitzer/add_param_documentation
(doc) Add documentation for apt::key parameters and apt::pin parameters
2015-02-04 23:50:37 +01:00
Hunter Haugen
95bed8902f Merge pull request #418 from cmurphy/rspec
Pin rspec gems
2015-02-04 12:04:17 -08:00
Colleen Murphy
553e3004ba Pin rspec gems 2015-02-04 17:03:32 +01:00
Merritt Krakowitzer
e8bef852ed (doc) Add documentation for apt::key parameters and apt::pin parameters
Add documentation for apt::key parameters and apt::pin parameters.
Fix minor spelling error
2015-02-03 18:59:54 +02:00
Daniele Sluijters
157262e795 Merge pull request #414 from phaf/fix_doc_unattended_upgrades
Documentation: Fix typo and syntax for example of apt::unattended_upgrad...
2015-01-30 14:22:18 +01:00
Patric Hafner
9545a85b06 Documentation: Fix typo and syntax for example of apt::unattended_upgrades 2015-01-29 14:48:47 +01:00
Morgan Haskel
2415f23fca Merge pull request #398 from irconan/backports-pin
Separate apt::pin for apt::backports to allow pin by release instead of ...
2015-01-28 08:36:01 -08:00
Richard Connon
64f9c76a49 Separate apt::pin for apt::backports to allow pin by release instead of origin
Updated tests for backports
2015-01-28 12:34:18 +00:00
Morgan Haskel
958a0c1750 Merge pull request #395 from udienz/master
Add Ubuntu vivid (15.04) release
2015-01-26 14:26:13 -08:00
tphoney
f238bfdbe7 Merge pull request #411 from mhaskel/trusted_fix
Trusted will be a reserved word in Puppet 4
2015-01-21 11:14:33 -08:00
Morgan Haskel
3d25c08ec1 Trusted will be a reserved word in Puppet 4
Rename the new `trusted` parameter to `trusted_source`.
2015-01-21 10:54:37 -08:00
Daniele Sluijters
646b407027 Merge pull request #407 from mkrakowitzer/f3792625/trusted_param
Add support for parameter trusted MODULES-1658
2015-01-20 16:05:44 -05:00
Merritt Krakowitzer
4f0ebaced7 Merge branch 'master' of https://github.com/puppetlabs/puppetlabs-apt into f3792625/trusted_param 2015-01-20 21:27:52 +02:00
Daniele Sluijters
6b23f3cb78 Merge pull request #403 from WolverineFan/fix_apt_updates_facts
Fix apt_has_updates fact not parsing apt-check output correctly
2015-01-20 12:39:46 -05:00
WolverineFan
e7fee16589 Fix apt_has_updates fact not parsing apt-check output correctly
The /usr/lib/update-notifier/apt-check script returns its output
to STDERR but a recent change to the script redirects STDERR to
/dev/null.  This will cause the array to always be empty.

Combined with that problem, while we were checking for the result
being nil, we never checked for an invalid array.  As a result,
the apt_has_updates was always true and the apt_updates and
apt_security_updates facts were trying to read from an empty array
and failing.
2015-01-16 17:45:55 -05:00
Colleen Murphy
6d60659e70 Merge pull request #409 from cyberious/MOD1661
MODULES-1661 Fix to do delete with short key not long
2015-01-14 08:25:47 -08:00
Travis Fields
18fae0a516 MODULES-1661 Fix to do delete with short key not long 2015-01-13 23:45:03 -08:00
Colleen Murphy
251bd23b5b Merge pull request #408 from cyberious/MODULES-1661
MODULES-1661 Fix issue with apt_key destroy, also added mutliple deletes
2015-01-13 17:41:49 -08:00
Travis Fields
f1ca76dec5 MODULES-1661 Fix issue with apt_key destroy, also added mutliple deletes 2015-01-13 17:40:18 -08:00
Merritt Krakowitzer
38582d02cd Add support for parameter trusted
* Add support for paramater trusted, valid options are 'true' and false.
defaults to false. True sets the value to trusted=yes.

trusted=yes can be set to indicate that packages from this source are
always authenticated even if the Release file is not signed or the
signature can't be checked.

* Update documentation
2015-01-13 17:41:20 +02:00
Daniele Sluijters
1a7d0790d5 Merge pull request #404 from WolverineFan/support_40char_fingerprints
Allow full length GPG key fingerprints.
2015-01-12 14:32:52 -05:00
rfkrocktk
445ad0b6fe Allow full length GPG key fingerprints.
Also add support for ECC and ECDSA key_types
2015-01-10 00:45:57 -05:00
Hunter Haugen
073096e697 Merge pull request #405 from petems/update_init_docs
Format documentation a little
2015-01-09 13:32:25 -08:00
Peter Souter
b3c61ce0bc Format documentation a little
Makes it a little easier to read and parse with scripts
2015-01-09 13:17:51 -08:00
Daniele Sluijters
65a5a25110 Merge pull request #400 from voidus/master
Allow ports that consist of 5 decimals
2015-01-08 09:14:55 +01:00
Simon Kohlmeyer
b0e0024730
Allow ports that consist of 5 decimals 2015-01-08 05:26:53 +01:00