Commit graph

1042 commits

Author SHA1 Message Date
David Schmitt
85af3d8aa3 Fix syntax error 2016-07-27 18:35:58 +01:00
David Schmitt
ade1eeb9d2 Merge pull request #617 from hunner/strict_error
(MODULES-3414) Limit non-strict parsing to pre-3.5.0 only
2016-07-27 16:54:36 +01:00
Hunter Haugen
360f04dcc1
(MODULES-3414) Limit non-strict parsing to pre-3.5.0 only
Puppet 3.5.0 introduced strict variables and the module handles strict
variables by using the defined() function. This does not work on prior
versions of puppet so we must gate based on that version.

Puppet 4 series has a new setting `strict` that may be set to enforce
strict variables while `strict_variables` remains unset (see PUP-6358)
which causes this conditional to erroniously use non-strict 3.5-era
parsing and fail.

The new conditional corrects the cases such that strict variable
behavior happens on versions 3.5.0 and later.
2016-07-27 08:39:42 -07:00
TP Honey
5e076fcc9e Merge pull request #615 from DavidS/modulesync
(MODULES-3581) modulesync [067d08a]
2016-07-08 14:44:44 +01:00
David Schmitt
0f9327bbf4 (MODULES-3581) modulesync [067d08a] 2016-07-08 13:34:01 +01:00
TP Honey
37c8d08d4e Merge pull request #613 from nicobn/master
Fixed "unless" test condition for ppa repository
2016-07-07 14:36:11 +01:00
Nick Berard
fcdd54de1d Replaced -s with -f in ppa rspec tests
See 38263ac768. The previous commit makes the tests fail.
2016-07-05 17:31:21 -07:00
Nick Berard
38263ac768 After the repository is added, the ${::apt::sources_list_d}/${sources_list_d_filename} file is created as an empty file.
The unless condition of Exec["add-apt-repository-${name}"] calls test -s, which returns 1 if the file is empty. Because
the file is empty, the unless condition is never true and the repository is added on every execution. This commit
replaces the -s test condition with -f, which is true if the file exists or false otherwise.
2016-07-01 17:31:05 -07:00
David Schmitt
ae8f96a093 Merge pull request #612 from puppetlabs/modulesync
{maint} modulesync 0794b2c
2016-06-30 13:43:26 +01:00
tphoney
2cb5f18acc {maint} modulesync 0794b2c 2016-06-30 11:53:46 +01:00
TP Honey
ad6c6073d3 Merge pull request #611 from mattkenn4545/master
Fix TYPO
2016-06-28 11:41:43 +01:00
Matthew Kennedy
85e2a7632c Fix TYPO
Ubuntu not Ubunto
2016-06-27 15:39:43 -06:00
Bryan Jen
5476d9033b Merge pull request #610 from puppetlabs/unused-lsb
apt/params: Remove unused LSB facts
2016-06-07 09:20:12 -07:00
Bryan Jen
efbe46bbc1 Merge pull request #609 from hfm/fix-regexp
Fix regexp for $ensure params
2016-06-06 09:25:07 -07:00
Daniele Sluijters
47b9b6dee7 apt/params: Remove unused LSB facts 2016-06-05 12:29:00 +02:00
OKUMURA Takahiro
459f515879 Fix regexp for $ensure params
/\Aabsent|present\Z/ match wrong values like 'absentaaa' or 'aaapresent'.

And add tests to the context of 'invalid ensure'.
2016-06-05 18:44:25 +09:00
Hunter Haugen
797974c0a2 Merge pull request #608 from DavidS/use-more-pool
Update tests to use the pool servers instead of ubuntu's
2016-05-24 12:40:20 -07:00
David Schmitt
4a39afa703 Update tests to use the pool servers instead of ubuntu's
Using the ubuntu keyserver causes stability issues during CI runs,
hopefully the pool servers are less fragile.
2016-05-24 20:00:13 +01:00
TP Honey
a2a9b9de57 Merge pull request #606 from DavidS/use-key-server-pool
Use hkps.pool.sks-keyservers.net instead of pgp.mit.edu
2016-05-24 14:32:58 +01:00
David Schmitt
fff34ecad3 Remove useless, failing test; cleanup whitespace 2016-05-24 12:20:49 +01:00
David Schmitt
1e1e4b566e Use hkps.pool.sks-keyservers.net instead of pgp.mit.edu
The MIT server is sometimes unreliable during tests. The pool should
provide a much stabler service.
2016-05-24 12:20:49 +01:00
David Schmitt
e0ee0995bb Merge pull request #607 from HelenCampbell/XenialTestFix
Removal of a breaking test for Xenial
2016-05-24 11:44:46 +01:00
Helen Campbell
b30cded624 Removal of a breaking test for Xenial 2016-05-23 17:02:26 +01:00
TP Honey
39870ce984 Merge pull request #605 from imphil/master
Install software-properties-common for xenial
2016-05-03 11:36:27 +01:00
Philipp Wagner
e651d7d25c Install software-properties-common for xenial
Instead of adding every newer release of Ubuntu, let's assume that the
package name that is used today will be used in the future, until the
next change is necessary.
2016-05-02 13:53:09 +02:00
TP Honey
24eb003630 Merge pull request #604 from tdb/fix_version_check
Fix version check on 16.04.
2016-04-28 11:40:52 +01:00
Tim Bishop
1f444343b4 Fix version check on 16.04.
The old test obviously broke on 16.04. Switch to using versioncmp
since it does the right thing for us.
2016-04-27 16:26:25 +01:00
David Schmitt
e9925384e2 Merge pull request #602 from DG-i/master
apt::setting expects priority to be an integer, set defaults accordingly
2016-04-19 14:22:38 +01:00
Mathias Merscher
e5d5123521 apt::setting expects priority to be an integer, set defaults accordingly
Signed-off-by: Mathias Merscher <Mathias.Merscher@dg-i.net>
2016-04-19 12:31:00 +02:00
Greg Hardy
d4b2e9021a Merge pull request #600 from puppetlabs/update-msync
Update to newest modulesync_configs [9ca280f]
2016-04-19 11:03:12 +01:00
David Schmitt
3717ce92ad Update to newest modulesync_configs [9ca280f] 2016-04-18 20:15:09 +01:00
TP Honey
015009d553 Merge pull request #596 from danielhoherd/master
Expose notify_update to apt::source
2016-04-12 10:46:39 +01:00
TP Honey
c04cd01290 Merge pull request #599 from DavidS/fix-strict-var-testing
Fix STRICT_VARIABLE testing
2016-04-07 19:09:05 +01:00
David Schmitt
5e0128cc86 (maint) clean up key_compat_specs 2016-04-07 18:33:55 +01:00
David Schmitt
c4899127ee (maint) Update ke_compat_spec to run under STRICT_VARIABLES 2016-04-07 18:31:58 +01:00
Hunter Haugen
00a21076d7 Merge pull request #581 from robinelfrink/master
Make apt_updates facts use /usr/bin/apt-get.
2016-04-07 10:13:46 -07:00
Daniel Hoherd
91092bdc80 Exposing notify_update to apt::source 2016-03-18 10:08:30 -07:00
Daniele Sluijters
252bb9fef6 Merge pull request #595 from danielhoherd/master
Typo: missing colon
2016-03-17 10:53:42 +01:00
Daniel Hoherd
6bd04e4e49 Typo: missing colon 2016-03-16 17:58:08 -07:00
Hunter Haugen
1e45278668 Merge pull request #593 from puppetlabs/2.2.x
Mergeback 2.2.x
2016-02-29 13:52:36 -08:00
David Schmitt
eee0a6b1e7 Merge pull request #592 from HelenCampbell/2.2.2
Prep for 2.2.2 Release
2016-02-25 13:45:59 +00:00
Helen Campbell
0cdb62359e Prep for 2.2.2 Release 2016-02-25 12:50:12 +00:00
Helen
f2a78eae72 Merge pull request #590 from DavidS/debian-8-support
Update metadata to note Debian 8 support
2016-02-17 12:13:16 +00:00
David Schmitt
429f0dda8b Update metadata to note Debian 8 support 2016-02-17 11:52:31 +00:00
TP Honey
2ddc359793 Merge pull request #589 from DavidS/fm-4046-update-msync
(FM-4046) Update to current msync configs [006831f]
2016-02-16 17:04:03 +00:00
David Schmitt
541585668b (FM-4046) Update to current msync configs [006831f]
This moves all copyright statements to the NOTICE file in accordance with the ASFs guidelines on applying the Apache-2.0 license.
2016-02-16 16:33:21 +00:00
Robin Elfrink
ebf9d9f6a6 Make apt_updates facts use /usr/bin/apt-get.
/usr/lib/update-notifier/apt-check is not available on all systems,
but /usr/bin/apt-get is.
2016-02-12 23:21:28 +01:00
Bryan Jen
cc537070e8 Merge pull request #582 from imphil/master
Look for correct sources.list.d file for apt::ppa
2016-02-04 12:29:15 -07:00
Philipp Wagner
a02654e36c Look for correct sources.list.d file for apt::ppa
In Ubuntu 15.10 the path of the apt sources file, which is generated by
apt-add-repository, changed to include the distid. This breaks apt::ppa
idempotency, since it does not recognize the repository is already
added.

Reported on puppet-users as well:
https://groups.google.com/forum/#!topic/puppet-users/YzeMyZYUo98
2016-02-03 17:24:06 +01:00
Philipp Wagner
4d66d23bec Ensure PPAs in tests have valid form
"man apt-add-repository" notes: "REPOSITORY can be either a line that
can be added directly to sources.list(5), in the form ppa:<user>/<ppa-name>
for adding Personal  Package  Archives".

Fix the tests to always use the format ppa:<user>/<ppa-name> when adding
PPAs.
2016-02-03 17:15:00 +01:00