Commit graph

758 commits

Author SHA1 Message Date
Daniele Sluijters
e588ab622b Merge pull request #443 from mhaskel/proxy_updates
proxy_* params were removed from class apt
2015-02-26 18:00:17 +01:00
Daniele Sluijters
a634fe2189 Merge pull request #441 from mhaskel/use_setting
Convert to use apt::setting instead of file resource
2015-02-26 18:00:02 +01:00
Morgan Haskel
351c8d5941 Convert to use apt::setting instead of file resources
This adds consistency across the module
2015-02-25 10:24:56 -08:00
Morgan Haskel
3e44b685d2 proxy_* params were removed from class apt
Add them to PPA since they were being used there, and add a placeholder
example for setting up the proxy files.
2015-02-25 09:56:24 -08:00
Daniele Sluijters
1c0c6f106a Merge pull request #442 from mhaskel/add_base_name
Add base_name parameter to apt::setting
2015-02-25 18:22:37 +01:00
Daniele Sluijters
fd71aedda7 Merge pull request #440 from mhaskel/fix_setting_validation
Allow priorities to be zero-padded
2015-02-25 18:22:04 +01:00
Morgan Haskel
1236ecff2c Add base_name parameter to apt::setting
This allows you to work around duplicate resource issues when you have
settings of different types with the same name. When the files are built
it is path/${priority}${base_name}${extension}.
2015-02-25 07:37:16 -08:00
Morgan Haskel
e0f058cc20 Allow priorities to be zero-padded 2015-02-25 07:33:05 -08:00
Daniele Sluijters
d6ac23f777 Merge pull request #439 from mhaskel/rspec3
Convert specs to RSpec 3.1.7 syntax with Transpec
2015-02-25 08:45:30 +01:00
Morgan Haskel
4e453191ea Merge pull request #438 from puppetlabs/daenney/cant-touch-params-nanananana
apt::params: Make the class private.
2015-02-24 16:14:23 -08:00
Morgan Haskel
1139f801eb Convert specs to RSpec 3.1.7 syntax with Transpec
This conversion is done by Transpec 3.0.8 with the following command:
    transpec spec/classes spec/defines spec/unit

* 87 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 14 conversions
    from: obj.should
      to: expect(obj).to

* 7 conversions
    from: == expected
      to: eq(expected)

* 1 conversion
    from: it { should_not ... }
      to: it { is_expected.not_to ... }

For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-02-24 13:20:29 -08:00
Daniele Sluijters
3b5145bf51 apt::params: Make the class private.
Prevent direct access to apt::params. This will ensure that any other
module cannot blindly access apt::params and get settings that have been
potentially overridden at the apt level.

Our own module still can since any class in apt has a module_name of
'apt' but that's up to us to prevent from happening.

Every setting must now be accessed by a qualified lookup into the apt
namespace.
2015-02-24 21:43:36 +01:00
Daniele Sluijters
cddf5498f0 Merge pull request #433 from mhaskel/ppa
PPA Cleanup, pt 1
2015-02-23 20:21:10 +01:00
Morgan Haskel
1b6e046bea PPA Cleanup, pt 1
Make the code much cleaner, but don't make a t&p.
2015-02-22 14:44:27 -08:00
Daniele Sluijters
c4981a0739 Merge pull request #432 from mhaskel/source_cleanup
Cleanup for `apt::source`
2015-02-22 00:30:36 +01:00
Morgan Haskel
10f313cfb4 Convert apt::source to use apt::setting
May as well use the define since we added it
2015-02-21 15:26:48 -08:00
Morgan Haskel
0a178c3382 Cleanup for apt::source
* Update `release` to default to `$::lsbdistcodename`
* Default `include_src` to false
* Validate more things!
* Stop redefining variables from `apt::params`
2015-02-21 15:26:48 -08:00
Daniele Sluijters
7e7e3e2f50 Merge pull request #435 from mhaskel/setting_fix
Type is a reserved word in puppet 4
2015-02-22 00:22:59 +01:00
Daniele Sluijters
f88008146a Merge pull request #431 from mhaskel/local_variable_declarations
Stop redeclaring variables from params
2015-02-22 00:22:25 +01:00
Morgan Haskel
7c5a62f13e Stop redeclaring variables from params
It really seems unnecessary.
2015-02-21 12:18:15 -08:00
Morgan Haskel
4f4d8aeafd Type is a reserved word in puppet 4
So replace `type` with `setting_type` in apt::setting
2015-02-21 11:50:00 -08:00
Morgan Haskel
e75e603d33 Merge pull request #428 from puppetlabs/daenney/apt-setting
apt: Add apt::setting defined type.
2015-02-21 11:40:05 -08:00
Daniele Sluijters
76c88af041 apt: Add apt::setting defined type.
This is a 'base' type. It's a simple wrapper around a file which takes
`type`, `ensure`, `content`, `source` and `file_perms`. It is intended
for usage by `apt::conf`, `apt::source` and an upcoming `apt::pref`.
2015-02-21 20:13:01 +01:00
Daniele Sluijters
92c405b19c Merge pull request #430 from mhaskel/fix_typo
Fix typo from #426
2015-02-20 22:06:50 +01:00
Daniele Sluijters
58f71679ba Merge pull request #429 from mhaskel/remove_include_update
Remove 'include apt::update'
2015-02-20 22:06:29 +01:00
Morgan Haskel
12a358912a Fix typo from #426
Too many `$`s
2015-02-20 10:55:47 -08:00
Morgan Haskel
0d9bab38cc Remove 'include apt::update'
It is included in `class apt`, and there are no promises about anything
working without that.
2015-02-20 10:47:35 -08:00
Morgan Haskel
59c362a2c1 Merge pull request #426 from puppetlabs/daenney/fix-missing-param-and-naming
apt::params: Add two missing entries, use them.
2015-02-19 16:41:27 -08:00
Daniele Sluijters
ab928276cb Merge pull request #427 from mhaskel/required_packages
RFC - Remove required packages
2015-02-20 01:10:45 +01:00
Daniele Sluijters
3e407d70e0 apt::params: Add two missing entries, use them. 2015-02-20 01:06:26 +01:00
Morgan Haskel
bb3a1f0af0 Remove required packages
I'm not entirely clear on the history behind this feature, and this
feels sort of hack-y. If you could explain why this is needed that would
be awesome, or if it isn't just merge this :)
2015-02-19 15:39:14 -08:00
Daniele Sluijters
463a61c0ab Merge pull request #424 from mhaskel/hulk_smash
Hulk smash
2015-02-19 19:35:50 +01:00
Morgan Haskel
59782daea1 Fix lint issue in examples 2015-02-19 08:26:30 -08:00
Morgan Haskel
9f758e8b5f Fix acceptance tests 2015-02-18 13:42:55 -08:00
Morgan Haskel
1534042c93 Fix broken unit tests 2015-02-18 11:43:50 -08:00
Morgan Haskel
e626423b57 Placeholders for needed examples 2015-02-15 11:17:12 -08:00
Morgan Haskel
e965fe450d Update examples 2015-02-15 11:11:58 -08:00
Morgan Haskel
8ef58a456d Get rid of hold 2015-02-15 10:59:00 -08:00
Morgan Haskel
0809774006 Get rid of release 2015-02-15 10:54:33 -08:00
Morgan Haskel
8cc7d40dd9 Get rid of force 2015-02-15 10:52:57 -08:00
Morgan Haskel
90cc951753 get rid of builddep 2015-02-15 10:45:54 -08:00
Morgan Haskel
6dc52c169e Merge pull request #1 from puppet-community/daenney/remove_unattended_upgrades_remains
Remove some vars for unattended_upgrades.
2015-02-15 10:41:54 -08:00
Daniele Sluijters
4def3987e0 Remove some vars for unattended_upgrades. 2015-02-15 19:40:42 +01:00
Morgan Haskel
501a1b5627 stop including params everywhere 2015-02-15 10:25:36 -08:00
Morgan Haskel
9debb1a909 Remove backports and debian 2015-02-15 10:22:37 -08:00
Morgan Haskel
b09a699b8c move tests to examples 2015-02-15 09:48:10 -08:00
Morgan Haskel
87b087e9c0 Get rid of unattended upgrades and cleanup unused templates 2015-02-15 09:46:04 -08:00
Morgan Haskel
6b5e4d1790 and an acceptance test 2015-02-15 09:41:20 -08:00
Morgan Haskel
61080fb676 Unbreak broken tests 2015-02-15 09:39:17 -08:00
Morgan Haskel
6cdbe562ab Starting to clean up init.pp 2015-02-15 09:09:47 -08:00