Commit graph

583 commits

Author SHA1 Message Date
Lauren Rother
2091b8b8cf Changes '[version]' and paragraph about override options
Changes '[version]' to 'x.y.z' based on feedback from ashp. Adds additional options to override options paragraphs.
2014-01-08 14:44:03 -08:00
Lauren Rother
c752a3da8f Update README
Edits sentences for spelling, capitalization, and grammar. Edits sentences for contextual consistency and clarity. Adds some missing descriptions.
2014-01-08 13:48:19 -08:00
Igor Galić
e667d52c91 Merge pull request #407 from johnsyweb/fix-documentation
Fix documentation
2014-01-02 16:30:36 -08:00
Ashley Penney
961cece2f9 Merge pull request #408 from zacharyalexstern/master
Fixed typo.
2013-12-27 19:25:00 -08:00
Zachary Alex Stern
0f3664f764 Fixed typo.
Noticed typo, figured I'd fix it.
2013-12-27 14:30:34 -08:00
Pete Johns
85afc5ca95 Fix typos 2013-12-27 19:48:27 +11:00
Pete Johns
52396510e8 s/options_override/override_options/g to prevent confusion 2013-12-27 19:43:35 +11:00
Ashley Penney
edfaeccfa8 Merge pull request #394 from danielfoglio/master
changed log_error to log-error and pid_file to pid-file to match the mys...
2013-12-19 16:39:56 -08:00
Ashley Penney
2df5aee8d5 Merge pull request #403 from apenney/fix-tests
Minor fix to beaker tests.
2013-12-19 16:36:02 -08:00
Ashley Penney
8c64e812d9 Minor fix to beaker tests. 2013-12-19 19:35:20 -05:00
Ashley Penney
c081327b1f Merge pull request #397 from srinathman/feature-create-db-if-exists
Added [if not exists] to [create database] clause.
2013-12-19 16:12:16 -08:00
Igor Galić
d5fd46de59 Merge pull request #400 from duritong/fix_backupuser_dependency
Fix backupuser dependency
2013-12-18 22:13:27 -08:00
Ashley Penney
3736fcb718 Merge pull request #398 from fridim/support_multiple_values_in_config
Support multiple lines of the same option
2013-12-18 13:41:32 -08:00
Guillaume Coré
dae8018520 Support multiple lines of the same option
Some MySQL options need to be passed several times. For example :

  http://dev.mysql.com/doc/refman/5.5/en/replication-options-slave.html#option_mysqld_replicate-do-db

  This is currently impossible with the override_options. This patch allows to
  pass array as value. Example :

    override_options => {
      'client' => {
        'password' => 'xxx',
      },
      'mysqld' => {
        'bind_address'    => '0.0.0.0',
        'replicate-do-db' => ['base1', 'base2', 'base3'],
      },
    }

  Which will be evaluated into :

    [client]
    password = xxx

    [mysqld]
    bind_address = 0.0.0.0
    replicate-do-db = base1
    replicate-do-db = base2
    replicate-do-db = base3
2013-12-18 16:00:12 -05:00
Hunter Haugen
8fbd595f89 Merge pull request #401 from apenney/restart
Restart
2013-12-18 12:22:21 -08:00
Ashley Penney
c32ae645e0 Apparently we were restarting no matter what the parameter said,
awkward.
2013-12-18 15:12:04 -05:00
Ashley Penney
5bba2e04b3 Add a comment to make this clearer. 2013-12-18 14:13:00 -05:00
Ashley Penney
ce77d067ef Fix a few tests. 2013-12-18 14:13:00 -05:00
Ashley Penney
b7dcdd1714 Add $restart support.
Previously this parameter did nothing, lets make it actually work.
2013-12-18 13:59:56 -05:00
mh
c57aa23e6f Use https url to make puppet-librarian more proxy-friendly
For people in restricted networks it's quite common to not
be able to use git:// urls, but https-urls work through proxies.
2013-12-18 13:36:49 +01:00
mh
765afe4f61 Fix #321 - root_user should be setup before configuring backup user
Otherwise puppet might try to setup the backup user even before
the service is running and will fail.
2013-12-18 13:35:20 +01:00
Foglio, Daniel
3d98b1de0d changed log_error to log-error and pid_file to pid-file to match the mysqld service script 2013-12-17 17:39:04 -05:00
Srinath M
a571df4c79 Fixed testing for creating a DB with the [if not exists] clause 2013-12-16 09:59:43 -05:00
Srinath M
1cc07977c5 Added [if not exists] to [create database] clause.
this should avoid errors like:
ERROR 1007 (HY000): Can't create database 'MyDB'; database exists

This error can cause a multi-master replication to stop due to conflicting
commands between nodes. For  example, if the command create DB is run in
 different nodes and then they will send it in the replication logs to each
other and then they will try to run them second time and fail.
2013-12-15 21:47:10 -05:00
Igor Galić
62eb73db07 Merge pull request #395 from doc75/fixes_my_cnf
my.cnf: typo fix (bind-address) + migrate key_buffer (deprecated) to key_buffer_size
2013-12-15 04:50:25 -08:00
Guillaume Virlet
3da12ac622 migrate key_buffer (deprecated) to key_buffer_size in config_file 2013-12-14 23:15:13 +01:00
Guillaume Virlet
9460db2ec1 fix typo on bind-address in config_file 2013-12-14 23:14:01 +01:00
Ashley Penney
9603d9a8aa Merge pull request #390 from apenney/add-more-tests
Add tests for all missing parameters.
2013-12-11 08:22:21 -08:00
Ashley Penney
50f0ef8477 Merge pull request #391 from vicinus/mysql_grant_fixes
Mysql grant fixes
2013-12-11 07:18:28 -08:00
Reinhard Vicinus
07c3b76eb9 mysql_grant bugfix: remove duplicate privileges and GRANT privilege, otherwise the resource gets changed every puppet run 2013-12-11 13:17:52 +01:00
Reinhard Vicinus
9de42ac43e mysql_grant bugfix: REVOKE ALL PRIVILEGES doesn't revoke GRANT OPTION 2013-12-11 13:16:14 +01:00
Reinhard Vicinus
f5a78f1c5f mysql_grant bugfix: on table *.* SHOW GRANT can return 'WITH MAX_QUERIES_PER_HOUR' which breaks the captures on the match 2013-12-11 13:15:21 +01:00
Ashley Penney
757102b353 Move to stdlib 3.2.0, which shipped in PE 3.0. 2013-12-10 18:22:02 -05:00
Ashley Penney
7224f12c25 Fixes to various failing tests. 2013-12-10 18:21:57 -05:00
Ashley Penney
90c5abc4bb Add tests for all missing parameters.
This commit adds tests for the parameters that were previously untested.
Most of this testing is light, but all parameters of the module are now
called at least once.  Generally we're testing the happy path, so these
need further work in future.
2013-12-10 16:56:20 -05:00
Ashley Penney
d69a5f15b3 Merge pull request #335 from hunner/add_beaker
Adding beaker-rspec test files
2013-12-09 10:13:48 -08:00
Hunter Haugen
0aed9e07f7 Adding beaker-rspec test files
These tests are more or less parity with the rspec-system tests, though
dependent on a few patches that still have to make it into beaker and
beaker-rspec
2013-12-06 14:52:41 -08:00
Igor Galić
38dc05a1b6 Merge pull request #375 from ezheidtmann/parameterize-backup-dir-mode
Parameterize backup directory mode and ownership
2013-11-17 07:49:56 -08:00
Igor Galić
6ae9bc61d4 Merge pull request #376 from w32-blaster/master
Type mysql_grant fixed, spec test created
2013-11-17 07:47:50 -08:00
Tamas Szasz
aee0e01d81 Type mysql_grant was limited to work only with resource names foo@localhost/*.* or foo@localhost/bar.* but NOT with root@localhost/@ which is the parsed value of "GRANT PROXY ON ''@'' TO 'root'@'localhost' WITH GRANT OPTION" grant line.
New spec test was created for the type mysql_grant.rb
2013-11-16 19:11:39 +01:00
Tamas Szasz
fbfc5d831f defaults_file methods removed from every provider (old & new) and moved
the method to the global mysql.rb which is now included in every provider
file.

Class from the global mysql.rb file is a parent of every provider.
2013-11-16 19:09:09 +01:00
Evan Heidtmann
c654fe1ba8 Parameterize backup directory mode and ownership 2013-11-15 20:55:21 -08:00
Ashley Penney
ae097c8d4e Merge pull request #377 from apenney/fix-stupid-test
Fix broken test on RedHat.
2013-11-14 15:41:21 -08:00
Ashley Penney
353c19dae8 Fix broken test on RedHat. 2013-11-14 18:40:46 -05:00
Ashley Penney
e303e361b7 Merge pull request #374 from apenney/210-release
Prepare a 2.1.0 release.
2013-11-13 10:08:53 -08:00
Ashley Penney
acb9cc92d8 Prepare a 2.1.0 release. 2013-11-13 13:08:15 -05:00
Ashley Penney
0b7d074d57 Merge pull request #364 from thedonkdonk/master
Some options can not take a argument.
2013-11-13 09:13:31 -08:00
Ashley Penney
f19e8574d1 Merge pull request #372 from apenney/fix-debian-tests
How embarrassing, the tests were broken on Debian.
2013-11-12 16:39:51 -08:00
Ashley Penney
250932245f How embarrassing, the tests were broken on Debian. 2013-11-12 19:39:08 -05:00
Ashley Penney
29952116ca Merge pull request #367 from w32-blaster/master
Method for loading .my.cnf file is changed from "defaults-file" to "defaults-extra-file" (mysql option)
2013-11-12 13:16:11 -08:00