Commit graph

1281 commits

Author SHA1 Message Date
Dan Bode
147cf40301 Merge pull request #102 from Mirantis/config-pidfile
Parameterized pidfile; critical for successful first restart
2012-08-21 22:50:29 -07:00
Eugene Kirpichov
6869b77541 Parameterized pidfile; critical for successful first restart 2012-08-21 18:32:34 -07:00
Martin Dluhos
04537908a9 Added an option to specify db status. 2012-08-21 15:40:42 -07:00
Dan Bode
96bfbdf91e Merge pull request #100 from mcary/patch-1
Clarify how to grant specific privileges with database_grant
2012-08-21 12:18:38 -07:00
mcary
0137e7edeb Clarify how to grant specific privileges with database_grant
When I tried to use database_grant, I assumed the privilege 
names would match the SQL GRANT command, for example, SELECT
or CREATE TEMPORARY TABLES.  But in fact the privilege names
are taken from columns of the mysql.db table.  As a result,
a row was created in mysqld.db, but none of the privileges 
I intended to grant were actually granted.

Someone else filed a ticket with the same issue:
http://projects.puppetlabs.com/issues/15808

Document that how to specify individual privileges in
README.md.
2012-08-21 10:42:20 -07:00
Dan Bode
3084f8c44c Merge pull request #97 from bodepd/revert
Revert "Merge pull request #90 from emonty/master"
2012-08-15 18:09:10 -07:00
Dan Bode
211da13545 Revert "Merge pull request #90 from emonty/master"
This reverts commit 063d72493c, reversing
changes made to 9c10b3a6c3.
2012-08-15 18:03:37 -07:00
Dan Bode
063d72493c Merge pull request #90 from emonty/master
Add a bunch of new parameters
2012-08-15 17:40:42 -07:00
Nan Liu
9c10b3a6c3 Merge pull request #96 from branan/missing_curly_brace
Put that curly brace in the right place this time
2012-08-14 10:11:07 -07:00
Branan Purvine-Riley
02695533c8 Put that curly brace in the right place this time 2012-08-14 10:09:33 -07:00
Nan Liu
ecf1f7685b Merge pull request #95 from branan/missing_curly_brace
Add a missing curly brace
2012-08-14 10:01:02 -07:00
Branan Purvine-Riley
1da8ae7a28 Add a missing curly brace 2012-08-14 09:58:35 -07:00
Dan Bode
c041fddbad Merge pull request #94 from hunner/amazon-linux
Add support for Amazon Linux.
2012-08-13 19:49:38 -07:00
Nick Osborn
65f72ad317 Add support for Amazon Linux. 2012-08-13 17:26:01 -07:00
Simon Effenberg
f13482bde2 New configuration define.
* added a define to easily create .cnf files in /etc/mysql/conf.d/
* fix wrong path for .my.cnf in /etc/
2012-08-13 10:59:28 +02:00
Monty Taylor
bdf181a155 Adjust location of apparmor module. 2012-08-12 07:03:24 -07:00
Monty Taylor
8e404d464b Add support for debian defaults file.
Debian defines a defaults file in /etc/mysql/debian.cnf that can be used
for system admin tasks. Use it if it's there.
2012-08-12 08:48:30 -04:00
Monty Taylor
8d97f5dca8 Add apparmor support. 2012-08-12 08:48:19 -04:00
Dan Bode
3ffa0bd66b Merge pull request #73 from razorsedge/mysqladmin_passwd
Escape $root_password during execs.
2012-08-09 09:26:54 -07:00
Michael Arnold
605fa718e1 Escape $root_password during execs.
Some characters used in a password can cause the shell in an exec to do
unexpected things unless the password is enclosed in single quotes.
Updated the rspec tests to deal with the password quoting.
2012-08-09 00:34:09 -07:00
Reid Vandewiele
8dac527b2a Add priv validation to database_grant provider
The mysql database_grant provider currently has what is arguably a heinous
design flaw. At present:

 1. The 'privileges' parameter for the database_grant type, mysql provider,
    does not expect the same syntax as the mysql Grant command ('SELECT',
    'UPDATE', 'DELETE', etc). Rather, it expects the user to supply column
    names used to store raw grants in the mysql.db or mysql.user tables
    internally ('Select_priv', 'Update_priv', 'Delete_priv', etc).

 2. If a user supplies `privileges => [ 'SELECT', 'INSERT' ]` instead of
    `privileges => [ 'Select_priv', 'Insert_priv' ]`, the provider fails
    silently and will continuously attempt to update the privileges with
    each successive puppet run. In the specific example provided, all privs
    for the user/db will be set to false since e.g. 'INSERT' does not match
    any valid privilege.

Unfortunately it doesn't look simple to modify the provider such that the
intuitive SELECT, DELETE, etc. keywords can be used without changing
existing behavior. Leaving that alone for now, it *is* pretty simple to add
a validation function that will at least fail cleanly if non-functional
privilege values are supplied that don't mean anything to the provider. If
the user is trying to use valid MySQL Grant syntax, the new validation
procedure will recognize this and suggest a correction. Hopefully giving
users this kind of warning will clue them in to what kind of input the
provider expects.
2012-08-04 10:28:06 -07:00
Monty Taylor
069dc48d38 Add parameterization changes from wikipedia. 2012-07-30 09:31:48 -05:00
Dan Bode
583e60fe84 Merge pull request #88 from branan/release_0.4.0
Update module for 0.4.0
2012-07-24 13:10:10 -07:00
Branan Purvine-Riley
14b612e26f Update module for 0.4.0 2012-07-24 12:20:03 -07:00
Dan Bode
be493c3a41 Merge pull request #87 from branan/fix_rspec_211
Fix negative tests on rspec 2.11
2012-07-23 16:45:08 -07:00
Branan Purvine-Riley
5c4f14e386 Fix negative tests on rspec 2.11 2012-07-23 16:39:37 -07:00
Branan Purvine-Riley
66c17cd14c Merge pull request #82 from agerlic/escape_database_name
escape database name
2012-07-16 11:19:32 -07:00
Branan Purvine-Riley
514eca4298 Merge pull request #83 from agerlic/add_db_to_database_grant
add missing db param to database_grant
2012-07-02 17:59:49 -07:00
Alexandre Gerlic
de0f749ea5 add missing db param to database_grant 2012-06-21 17:27:39 +02:00
Alexandre Gerlic
2817f362d5 escape database name 2012-06-20 23:58:34 +02:00
Branan Purvine-Riley
920d25d273 Merge pull request #81 from bodepd/enabled_param
Add enabled parameter to mysql::server
2012-06-18 15:48:51 -07:00
Dan Bode
8b2b29a136 Add enabled parameter to mysql::server
This parameter can be used to specify whether the service
should be running.

It has been implemented to allow installations of mysql::server to
be in passive mode for HA.
2012-06-18 14:09:42 -07:00
Nan Liu
01fe9e55b7 Merge pull request #79 from branan/use_spechelper_gem
Switch to using the puppetlabs_spec_helper gem for common files
2012-06-08 13:37:57 -07:00
Branan Purvine-Riley
62b395fe69 Switch to using the puppetlabs_spec_helper gem for common files 2012-05-31 15:32:36 -07:00
Nan Liu
d66607d21a Merge pull request #78 from branan/merge_freebsd
Add freebsd support.
2012-05-31 09:18:15 -07:00
William Van Hevelingen
f572b90f9e (#14330) Add FreeBSD spec tests 2012-05-30 19:12:57 -07:00
William Van Hevelingen
05d7e23fe8 (#14330) Add support for FreeBSD
Note: ssl_ca, ssl_cert, and ssl_key do not have sane
defaults in FreeBSD. Setting ssl to true will require
setting the parameters mentioned above.
2012-05-30 19:12:25 -07:00
Dan Bode
ece11c57fa Merge pull request #77 from branan/updated_module_layout
Update the module to the new layout for easier testing and packaging
2012-05-25 16:10:53 -07:00
Branan Purvine-Riley
262449068d Add a clean task 2012-05-25 11:09:21 -07:00
Branan Purvine-Riley
703c0bde30 Update the module to the new layout for easier testing and packaging
* Add spec_full, spec_prep, and spec_clean targets
* Rename Gemfile -> .gemfile for less cluttered module packages
* Append fixtuers to modulepath instead of overwriting
* Use a more complete .gitignore
* Remove the recursive symlink
2012-05-24 16:55:22 -07:00
Dan Bode
c1e3bcabf4 Merge pull request #76 from brdude/master
Default types hacks not needed.
2012-05-22 16:59:40 -07:00
Rodrigo Menezes
f0f9e76db7 Default types hacks not needed.
Default types hacks not needed.
2012-05-22 16:50:46 -07:00
Dan Bode
65de49f090 Merge pull request #74 from jmchilton/specify_engine
Allow consumer to specify default storage engine for MySQL server.
2012-05-15 18:07:46 -07:00
John Chilton
41be95e262 Add spec's to test setting default storage engine. 2012-05-15 12:42:32 -05:00
John Chilton
0f0928ae88 Allow specification of storage engine. 2012-05-15 12:37:03 -05:00
Dan Bode
360f8d968a Merge pull request #64 from runningman/backup
Added mysql::backup class.
2012-05-10 22:44:52 -07:00
Dan Bode
0178347392 Merge pull request #72 from branan/travisci
Update Travis CI config
2012-05-08 10:25:44 -07:00
Branan Purvine-Riley
e3a0703c6c Add mocha to gemfile 2012-05-08 10:10:37 -07:00
Branan Purvine-Riley
02089f4faf Update travis config for our testing targets 2012-05-08 10:10:24 -07:00
Dan Bode
05f7807fc0 Merge pull request #71 from runningman/security
Fixed regex of database user.
2012-05-06 23:56:01 -07:00