Commit graph

1250 commits

Author SHA1 Message Date
Martin Mörner
6cac0384ad Fix global parameter usage in backup script
If mysqldump uses --defaults-extra-file mysql should use the same. Otherwise settings like different socket paths etc. will not work. Preferably this should be detected via test cases, as backups are quite important...
2016-05-20 10:11:25 +02:00
Hunter Haugen
e71e712f31 Merge pull request #829 from vicinus/master
remove erroneous anchors to mysql::client from mysql::db

Over zealous containment is considered a bug, and #605 introduced inflexibilities that should have been solved at the profile level (ie, make apt update run early).
2016-05-19 10:39:46 -07:00
Nemanja Delic
352d078ed5 moving mysqld.log resource to installdb.pp (#833) 2016-05-19 10:19:01 -07:00
Bryan Jen
f8ef652e2d Merge pull request #838 from glorpen/scripts
Support mysql_install_db script on Gentoo
2016-05-19 10:13:18 -07:00
David Schmitt
cb0b0a6d62 Merge pull request #837 from megianni/master
Fixed an issue with Amazon linux major release 4 installation
2016-05-19 15:44:10 +01:00
Arkadiusz Dzięgiel
41e4753bd2 Support mysql_install_db script on Gentoo
On Gentoo, mysql_install_db script is installed into /usr/share/mysql/scripts
and therefore is not found by mysql_datadir type.
This commit adds scripts path to ENV['PATH'] so it can be found.
2016-05-19 12:20:51 +02:00
Matias Gianni
5a7e34b0ac Fixed an issue with Amazon linux major release 4 that would make the module exit with and error message 2016-05-18 11:47:42 -03:00
JT (Jonny)
d5d2de7719 Merge pull request #836 from fschndr/master
default group for logfiles on Debian/Ubuntu should be adm
2016-05-16 13:33:24 +01:00
Fabian
cffc883e27 default group for logfiles on Debian/Ubuntu should be adm 2016-05-12 17:11:29 +02:00
JT (Jonny)
3e3cd55e04 Merge pull request #830 from fvanboven/module-2111-replication
(MODULES-2111) Add the system database to user related actions.
2016-05-10 11:30:28 +01:00
JT (Jonny)
13a8d807d5 Merge pull request #828 from s-t-e-v-e-n-k/mysql-type-xenial
Remove mysql regex when checking type
2016-05-09 18:39:07 +01:00
JT (Jonny)
2cf6000c55 Merge pull request #834 from jonnytpuppet/alwiesner/master
Check that /var/lib/mysql actually contains files.
2016-05-09 18:36:48 +01:00
Al Wiesner
06fe1f9abb Check that /var/lib/mysql actually contains files.
MySQL-server-advanced installs install the 'mysql' directory in /var/lib/mysql by default,
therefore the check fails and does not run mysql_install_db.
Check is adjusted to check if any files exist in the directory.
2016-05-09 18:35:48 +01:00
Igor Galić
9801483727 Merge pull request #831 from fraenki/freebsd_mysqld
make sure we find mysqld on FreeBSD
2016-05-07 14:10:10 +02:00
Frank Wall
e52a669410 make sure we find mysql commands on FreeBSD 2016-05-06 01:45:46 +02:00
Frank van Boven
b8d301527e (MODULES-2111) Add the system database to user related tables.
Change the behaviour of applying user and grant related changes to use
the system database of MySQL.

This is a workaround to fix a bug in MySQL
(https://bugs.mysql.com/bug.php?id=65923) that causes users and grants
to be replicated, even if the "mysql" database should not be replicated.
2016-05-02 14:52:44 +02:00
Steve Kowalik
c63e318df8 Remove mysql regex when checking type
Since the default MySQL return type is 'mysql', only check for MariaDB
and Percona specially.
2016-04-29 14:40:30 -05:00
Hunter Haugen
2603411dac Merge pull request #824 from ih84ds/patch-1
Default mysqld_type should be "mysql"
2016-04-25 16:29:21 -07:00
Hunter Haugen
c3820ecde4 Merge pull request #827 from lcrisci/master
Added bzip2 package support on mysqldump backup
2016-04-25 15:54:05 -07:00
LaurentCrisci
cda93b8452 Using ensure_packages instead of package 2016-04-25 13:29:36 +01:00
LaurentCrisci
0ad4f71934 Added bzip2 package support on mysqldump backup
The script used by this mysqldump class, mysqlbackup.sh, requires bzcat
which is part of the bzip2 package.

This patch will make sure that bzip2 is installed before setting up the
cron tab job using mysqlbackup.sh
2016-04-25 13:17:33 +01:00
David Schmitt
3c9f8ae78a Merge pull request #819 from aerostitch/fix_percona_centos
Add documentation example for Perconna installation on Centos
2016-04-25 09:37:37 +01:00
David Schmitt
8caf42eff7 Merge pull request #818 from hubspotdevops/percona
Add support for Percona 5.7
2016-04-25 09:36:42 +01:00
Monty Solomon
d472d5bcf1 Use defaults_extra_file first; add debug messages
Remove added notices and revert to debug

Add support for Percona

Use log-error for mysqld initialize

Improve description of error log argument

Should be --log-error
2016-04-21 01:00:40 -04:00
Joseph Herlant
ff39b730cc Adding documentation on the specific case of Percona server on Centos 2016-04-19 14:16:44 -07:00
Greg Hardy
9bc20bd7cc Merge pull request #823 from puppetlabs/update-msync
Update to newest modulesync_configs [9ca280f]
2016-04-19 11:35:35 +01:00
David Schmitt
04fb127bec Update to newest modulesync_configs [9ca280f] 2016-04-18 20:15:09 +01:00
ih84ds
5695cef4a6 Default mysqld_type should be "mysql"
Default mysqld_type return value should be "mysql" if another type is not detected. Returning nil breaks mysql 5.7.11 on Ubuntu (at least) due to the conditional used in mysql_user provider.
2016-04-14 17:55:22 -05:00
David Schmitt
f8ae5bf6ba (FM-5050) Configure the configfile's location for mariadb
As a follow-up to the includedir fix, with mariadb, $includedir is not
set, but the configfile is still placed in a directory that will only
be created by installing the package. This patch adds that directory,
if necessary.
2016-04-14 14:33:43 +01:00
Helen
ee51d4c442 Merge pull request #821 from DavidS/fix-debian-failures
(FM-5050) Configure the base of includedir
2016-04-13 16:02:32 +01:00
David Schmitt
232ef1818c (FM-5050) Configure the base of includedir
Without this change installing mysql fails with the following errors on Debian and
Ubuntu:

Error: Cannot create /etc/mysql/conf.d; parent directory /etc/mysql does not exist
Error: /Stage[main]/Mysql::Server::Config/File[/etc/mysql/conf.d]/ensure: change from absent to directory failed: Cannot create /etc/mysql/conf.d; parent directory /etc/mysql does not exist
Error: Could not set 'file' on ensure: No such file or directory @ dir_s_rmdir - /etc/mysql/my.cnf20160413-2395-1uo3ffj.lock at 39:/etc/puppetlabs/code/modules/mysql/manifests/server/config.pp
Error: Could not set 'file' on ensure: No such file or directory @ dir_s_rmdir - /etc/mysql/my.cnf20160413-2395-1uo3ffj.lock at 39:/etc/puppetlabs/code/modules/mysql/manifests/server/config.pp
Wrapped exception:
No such file or directory @ dir_s_rmdir - /etc/mysql/my.cnf20160413-2395-1uo3ffj.lock
Error: /Stage[main]/Mysql::Server::Config/File[mysql-config-file]/ensure: change from absent to file failed: Could not set 'file' on ensure: No such file or directory @ dir_s_rmdir - /etc/mysql/my.cnf20160413-2395-1uo3ffj.lock at 39:/etc/puppetlabs/code/modules/mysql/manifests/server/config.pp
2016-04-13 14:39:22 +01:00
Bryan Jen
696aff601e Merge pull request #820 from hunner/fix_opensuse
(MODULES-1256) Fix parameters on OpenSUSE 12
2016-04-11 16:33:09 -07:00
Hunter Haugen
67ea1c4dd3 (MODULES-1256) Fix parameters on OpenSUSE 12 2016-04-11 14:49:18 -07:00
Reinhard Vicinus
9fe85340f4 removed erroneous dependencies 2016-04-08 16:55:57 +02:00
TP Honey
2069c8959a Merge pull request #817 from DavidS/install-staging-acceptance
(maint) Add missing nanliu/staging module
2016-04-05 15:37:05 +01:00
David Schmitt
9aadcebb1b (maint) Add missing nanliu/staging module
The module is not really used, but its absence creates nasty warning
messages.
2016-04-05 14:52:29 +01:00
Igor Galić
9501649234 Merge pull request #815 from puppetlabs/remove_function
Remove mysql_table_exists() function
2016-03-29 16:18:42 +02:00
Igor Galić
b41dc6f4b3 Merge pull request #813 from tomkrouper/config-before-install
Config before install
2016-03-29 16:16:11 +02:00
Bryan Jen
906f99e1c1 Merge pull request #811 from pashamesh/fix-mysqlbackup-globals-ignored
Fixed global parameters skipped
2016-03-28 12:39:50 -07:00
Hunter Haugen
f4fe313e65 Remove mysql_table_exists() function
This function is intended to check for the existence of a table before
declaring some resource, but this is neither portable (because functions
orun on the master, not the agent) nor one-run idempotent (because the
function would run before mysql is even installed, and would take two
runs to do anything).

The correct way of doing this would be to update the providers and
dependency ordering to handle the conditional states.

Luckily this was never released so it is backwards compatible.
2016-03-28 10:48:58 -07:00
Bryan Jen
2ff7b3dbe2 Merge pull request #816 from hunner/fix_dump
Allow mysql::backup::mysqldump to access root_group in tests
2016-03-28 10:44:54 -07:00
Hunter Haugen
d8206aa4ec Allow mysql::backup::mysqldump to access root_group in tests 2016-03-25 15:31:15 -07:00
Tom Krouper
8b366fe7df Move config install before package install
This prevents mysqld from running without its intended configuration.
2016-03-25 09:01:31 -07:00
Bryan Jen
1835ea8f25 Merge pull request #812 from koubas/fix_debian_mariadb_detection
Loosen MariaDB recognition to fix it on Debian 8
2016-03-21 15:52:11 -07:00
Jakub Husak
1a67c3868b Loosen MariaDB recognition to fix it on Debian 8 2016-03-18 16:26:48 +01:00
Pasha MESH
8a38fe9bd0 Fixed global parameters skipped
Fixed problem with ignoring parameters from global configs
2016-03-17 19:32:39 +03:00
Igor Galić
d58a100fa6 Merge pull request #810 from occelebi/backupdir
Ensure backup directory exist
2016-03-14 20:58:16 +01:00
Onur Cem Celebi
1bd7b7be83 Ensure backup directory exist 2016-03-14 16:44:43 +01:00
Hunter Haugen
9d611106bb Merge pull request #808 from mmalchuk/master
Use mysql_install_db only with uniq defaults-extra-file
2016-03-11 13:39:30 -08:00
Maksim Malchuk
61619f69fc Use mysql_install_db only with uniq defaults-extra-file
Executing mysql_install_db with the defaults-extra-file set to the
global option file can produce errors with duplicates. For example it
happens when 'ignore-db-dir' option passed to $override_options in
mysql::server class. Same as https://bugs.mysql.com/bug.php?id=69441
2016-03-11 22:24:55 +03:00