Commit graph

565 commits

Author SHA1 Message Date
Guillaume Coré
dae8018520 Support multiple lines of the same option
Some MySQL options need to be passed several times. For example :

  http://dev.mysql.com/doc/refman/5.5/en/replication-options-slave.html#option_mysqld_replicate-do-db

  This is currently impossible with the override_options. This patch allows to
  pass array as value. Example :

    override_options => {
      'client' => {
        'password' => 'xxx',
      },
      'mysqld' => {
        'bind_address'    => '0.0.0.0',
        'replicate-do-db' => ['base1', 'base2', 'base3'],
      },
    }

  Which will be evaluated into :

    [client]
    password = xxx

    [mysqld]
    bind_address = 0.0.0.0
    replicate-do-db = base1
    replicate-do-db = base2
    replicate-do-db = base3
2013-12-18 16:00:12 -05:00
Hunter Haugen
8fbd595f89 Merge pull request #401 from apenney/restart
Restart
2013-12-18 12:22:21 -08:00
Ashley Penney
c32ae645e0 Apparently we were restarting no matter what the parameter said,
awkward.
2013-12-18 15:12:04 -05:00
Ashley Penney
5bba2e04b3 Add a comment to make this clearer. 2013-12-18 14:13:00 -05:00
Ashley Penney
ce77d067ef Fix a few tests. 2013-12-18 14:13:00 -05:00
Ashley Penney
b7dcdd1714 Add $restart support.
Previously this parameter did nothing, lets make it actually work.
2013-12-18 13:59:56 -05:00
Igor Galić
62eb73db07 Merge pull request #395 from doc75/fixes_my_cnf
my.cnf: typo fix (bind-address) + migrate key_buffer (deprecated) to key_buffer_size
2013-12-15 04:50:25 -08:00
Guillaume Virlet
3da12ac622 migrate key_buffer (deprecated) to key_buffer_size in config_file 2013-12-14 23:15:13 +01:00
Guillaume Virlet
9460db2ec1 fix typo on bind-address in config_file 2013-12-14 23:14:01 +01:00
Ashley Penney
9603d9a8aa Merge pull request #390 from apenney/add-more-tests
Add tests for all missing parameters.
2013-12-11 08:22:21 -08:00
Ashley Penney
50f0ef8477 Merge pull request #391 from vicinus/mysql_grant_fixes
Mysql grant fixes
2013-12-11 07:18:28 -08:00
Reinhard Vicinus
07c3b76eb9 mysql_grant bugfix: remove duplicate privileges and GRANT privilege, otherwise the resource gets changed every puppet run 2013-12-11 13:17:52 +01:00
Reinhard Vicinus
9de42ac43e mysql_grant bugfix: REVOKE ALL PRIVILEGES doesn't revoke GRANT OPTION 2013-12-11 13:16:14 +01:00
Reinhard Vicinus
f5a78f1c5f mysql_grant bugfix: on table *.* SHOW GRANT can return 'WITH MAX_QUERIES_PER_HOUR' which breaks the captures on the match 2013-12-11 13:15:21 +01:00
Ashley Penney
757102b353 Move to stdlib 3.2.0, which shipped in PE 3.0. 2013-12-10 18:22:02 -05:00
Ashley Penney
7224f12c25 Fixes to various failing tests. 2013-12-10 18:21:57 -05:00
Ashley Penney
90c5abc4bb Add tests for all missing parameters.
This commit adds tests for the parameters that were previously untested.
Most of this testing is light, but all parameters of the module are now
called at least once.  Generally we're testing the happy path, so these
need further work in future.
2013-12-10 16:56:20 -05:00
Ashley Penney
d69a5f15b3 Merge pull request #335 from hunner/add_beaker
Adding beaker-rspec test files
2013-12-09 10:13:48 -08:00
Hunter Haugen
0aed9e07f7 Adding beaker-rspec test files
These tests are more or less parity with the rspec-system tests, though
dependent on a few patches that still have to make it into beaker and
beaker-rspec
2013-12-06 14:52:41 -08:00
Igor Galić
38dc05a1b6 Merge pull request #375 from ezheidtmann/parameterize-backup-dir-mode
Parameterize backup directory mode and ownership
2013-11-17 07:49:56 -08:00
Igor Galić
6ae9bc61d4 Merge pull request #376 from w32-blaster/master
Type mysql_grant fixed, spec test created
2013-11-17 07:47:50 -08:00
Tamas Szasz
aee0e01d81 Type mysql_grant was limited to work only with resource names foo@localhost/*.* or foo@localhost/bar.* but NOT with root@localhost/@ which is the parsed value of "GRANT PROXY ON ''@'' TO 'root'@'localhost' WITH GRANT OPTION" grant line.
New spec test was created for the type mysql_grant.rb
2013-11-16 19:11:39 +01:00
Tamas Szasz
fbfc5d831f defaults_file methods removed from every provider (old & new) and moved
the method to the global mysql.rb which is now included in every provider
file.

Class from the global mysql.rb file is a parent of every provider.
2013-11-16 19:09:09 +01:00
Evan Heidtmann
c654fe1ba8 Parameterize backup directory mode and ownership 2013-11-15 20:55:21 -08:00
Ashley Penney
ae097c8d4e Merge pull request #377 from apenney/fix-stupid-test
Fix broken test on RedHat.
2013-11-14 15:41:21 -08:00
Ashley Penney
353c19dae8 Fix broken test on RedHat. 2013-11-14 18:40:46 -05:00
Ashley Penney
e303e361b7 Merge pull request #374 from apenney/210-release
Prepare a 2.1.0 release.
2013-11-13 10:08:53 -08:00
Ashley Penney
acb9cc92d8 Prepare a 2.1.0 release. 2013-11-13 13:08:15 -05:00
Ashley Penney
0b7d074d57 Merge pull request #364 from thedonkdonk/master
Some options can not take a argument.
2013-11-13 09:13:31 -08:00
Ashley Penney
f19e8574d1 Merge pull request #372 from apenney/fix-debian-tests
How embarrassing, the tests were broken on Debian.
2013-11-12 16:39:51 -08:00
Ashley Penney
250932245f How embarrassing, the tests were broken on Debian. 2013-11-12 19:39:08 -05:00
Ashley Penney
29952116ca Merge pull request #367 from w32-blaster/master
Method for loading .my.cnf file is changed from "defaults-file" to "defaults-extra-file" (mysql option)
2013-11-12 13:16:11 -08:00
Tamas Szasz
4ac8879734 Fixed missing parent for global mysql class
Added "require" to the global mysql.rb file like in the other provider files.

defaults-file changed to defaults-extra-file in all the database_* (old) providers, the same as in the mysql_* providers.

Changed defaults-file to defaults-extra-file in all test files
2013-11-12 21:32:41 +01:00
Ashley Penney
17b0a553b5 Merge pull request #369 from theasci/feature-hiera-integration
Updates to "Feature hiera integration"
2013-11-11 10:25:32 -08:00
w32-blaster
e315ee96d0 Changed defaults-file to defaults-extra-file
Should load the .my.cnf file with "--defaults-extra-file" instead of "--defaults-file". This is necessary if we have global my.cnf file but we want to use both of them.
2013-11-11 18:48:00 +01:00
Mason Malone
e947eaf6ee Adding tests for mysql::server::providers 2013-11-11 10:56:55 -05:00
Ashley Penney
8505ffe650 Merge pull request #368 from theasci/feature-hiera-integration
Better Hiera integration
2013-11-11 07:21:44 -08:00
Mason Malone
d07eaf3e86 Typos in README 2013-11-11 09:59:40 -05:00
Mason Malone
b86de6b88e Comment mysql::server::providers and update README.md
I added a "$" to the parameter examples because the Github syntax highlighting
looks off without it.
2013-11-11 09:57:31 -05:00
Mason Malone
d66efd82a2 Better hiera integration
This adds hash parameters to mysql::server to allow specifying grants, users, and databases to
create automatically, which works nicely with Hiera's automatic parameter lookup functionality
2013-11-10 22:25:55 -05:00
James Glenn
fc14afe4c0 Some options can not take a argument. Gets rid of the '= true' when an option is set to true. See Issues #338 and #363 2013-11-06 14:21:22 -06:00
Ashley Penney
911dbe5c1a Merge pull request #362 from apenney/fix/user
Fix owner -> user typo.
2013-11-06 08:37:28 -08:00
Ashley Penney
52b8714081 Fix owner -> user typo. 2013-11-06 11:36:55 -05:00
Ashley Penney
621774ae6b Merge pull request #355 from tekenny/master
added * for table name in title to match documented usage
2013-11-05 12:36:51 -08:00
Igor Galić
333be5fd76 ensure /root/.my.cnf is 0600 and root owned
explicitly set /root/.my.cnf's owner and mode to ensure it will be
created with as root owned and 0600. This change fixes #357
2013-11-05 19:56:27 +01:00
Ashley Penney
a3bc25935b Merge pull request #358 from apenney/fix/anchor
Fix the broken anchoring.
2013-11-05 09:11:00 -08:00
Ashley Penney
a4d329f846 Fix the broken anchoring. 2013-11-05 16:41:41 +01:00
Thomas Kenny
88e033fe88 added * for table name in title to match documented usage 2013-11-04 20:49:24 -05:00
Ashley Penney
ae32cdf862 Merge pull request #343 from Bit-Doctor/patch-1
Add Anchor pattern to client.pp
2013-11-04 08:57:39 -08:00
Ashley Penney
56c2639e71 Merge pull request #349 from Element84/SpecDeprecationWarning
Deprecation warning when running rake:spec
2013-11-04 08:56:29 -08:00