Commit graph

53 commits

Author SHA1 Message Date
Jeff McCune
06b549b028 Update CHANGELOG, Modulefile and README for 2.1.0 2011-08-17 16:37:20 -07:00
Jeff McCune
82267be5be Merge branch 'ticket/v2.x/9080_add_static_facts' into v2.x
* ticket/v2.x/9080_add_static_facts:
  (#9080) Add facts from /etc/puppetlabs/facts.d
2011-08-17 16:32:46 -07:00
Jeff McCune
95c88a1305 (#9080) Add facts from /etc/puppetlabs/facts.d
This fact is a direct copy of R.I.'s work at
https://github.com/ripienaar/facter-facts

This is necessary plumbing to allow the installer to write a simple text
file based on the role the node is receiving.  For example:

    $ cat /etc/puppetlabs/facts.d/puppet_enterprise_mcollective.txt
    fact_stomp_port=61613
    fact_stomp_server=puppetmaster
    fact_is_puppetagent=true
    fact_is_puppetmaster=true

The mcollectivepe module relies on these facts being set and we need a
persistent place to write them during the interview process and later
read them when puppet agent runs to configure MCollective on the agent
systems.

Since stdlib is a public module, both /etc/facts.d and
/etc/puppetlabs/facts.d are scanned for static facts.
2011-08-17 16:25:29 -07:00
Jeff McCune
e8fb6917d1 Merge pull request #11 from jeffmccune/ticket/master/8793_cut_version_2.0.0
Update CHANGELOG and Modulefile for 2.0.0 release

Reviewed-by: Dan Bode
2011-08-08 11:00:26 -07:00
Jeff McCune
666225c988 Update CHANGELOG and Modulefile for 2.0.0 release 2011-08-08 10:38:56 -07:00
Ken Barber
ef4ef11ae0 Merge pull request #10 from jeffmccune/ticket/master/8792_rename_whole_line_to_file_line
(#8792) Rename whole_line type to file_line.
2011-08-08 09:47:30 -07:00
Jeff McCune
f3c53e6f19 (#8792) Rename basic smoke test to reflect file_line rename
Without this patch the basic smoke test in the module tests/ directory
did not math up with the renamed whole_line => file_line resource type.

This patch updates the smoke test file to match the most recently
selected name of file_line.  The filename has been changed, comments
added to the smoke test file, and resource declarations inside the file
changed.
2011-08-08 09:33:56 -07:00
Jeff McCune
4c93090e1a (#8792) Rename whole_line type to file_line
Without this patch the resource whole_line would be included in the
stable stdlib module shipping in PE 1.2.  Ideally the name will be
stable and unchanging in the future.

There was quite a bit of concern over whole_line being an unwise name.
file_line appears to be the most suitable name and least likely to need
another rename in the future.
2011-08-04 19:17:48 -07:00
Jeff McCune
07d0eca317 Update CHANGELOG and Modulefile for 1.1.0 2011-08-04 18:34:32 -07:00
Jeff McCune
ee1081571e Merge branch 'refactor/master/8665_whole_line'
* refactor/master/8665_whole_line:
  (#8665) Change type from append_line to whole_line
2011-08-04 17:58:05 -07:00
Jeff McCune
0466e1bc6f Update CHANGELOG and README for 1.0.0 2011-08-04 17:24:46 -07:00
Jeff McCune
7e3b9b728a Merge branch 'ticket/master/8678_validate_array_string'
* ticket/master/8678_validate_array_string:
  (#8678) Add validate_array and validate_string functions
2011-08-04 16:07:46 -07:00
Jeff McCune
7393de9895 (#8678) Add validate_array and validate_string functions
The accounts module is making use of validate_array() and
validate_string() which do not exist int he stdlib module without this
patch.

This patch adds the two functions to the stdlib with unit tests.

Reviewed-by: Dan Bode
2011-08-04 16:05:39 -07:00
Jeff McCune
66cfee6f22 Merge branch 'ticket/master/8717_merge_function_ruby_185'
* ticket/master/8717_merge_function_ruby_185:
  (#8717) Make merge() function work with Ruby 1.8.5
2011-08-01 11:48:50 -07:00
Jeff McCune
4725c97102 (#8717) Make merge() function work with Ruby 1.8.5
The previous behavior of the merge() function used Array#inject with two
arguments.  Ruby 1.8.5 only supports inject being used with one
argument.

This change initializes and empty Hash object and merges each argument
into the accumulator.  The last argument still "wins" in the merge.

rspec tests (cd spec; rspec **/*_spec.rb) verified as passing with this
change.

Reviewed-by: Dan Bode
2011-08-01 11:45:08 -07:00
Dan Bode
2e3d49d174 Merge branch 'feature/master/add_merge_has_key' 2011-07-29 15:42:53 -07:00
Dan Bode
c4a13acafe (#8709) Add hash merging function
In Puppet, it is not possible to reassign hash
values.

This function allows a reasonable way to perform
hash munging in Puppet.

Reviewed-by: Jeff McCune
2011-07-29 15:28:21 -07:00
Dan Bode
b1beaec2da (#8708) Add has_key function
It is difficult to use existance of keys in a hash
as a boolean condition in Puppet (see #8705)

This function provides a working solution until
the underlying issue in Puppet can be resolved.

Reviewed-by: Jeff McCune
2011-07-29 15:11:10 -07:00
Dan Bode
4540949d96 (#8665) Change type from append_line to whole_line
Changed the type name from append_line to
whole_line.

After feedback that having a type with a verb in
the name was confusing.
2011-07-27 15:28:44 -07:00
Jeff McCune
9560b6336c Merge branch 'ticket/master/8585_load_yaml_function'
* ticket/master/8585_load_yaml_function:
  (#8575) Add loadyaml() function
2011-07-26 15:46:23 -07:00
Jeff McCune
8a46e201fe (#8575) Add loadyaml() function
This change adds a loadyaml() puppet function that takes a path to a
YAML data file and returns the contents as a Puppet variable.  There is
currently no validation of the contents of the file.

This commit is intentionally lacking unit tests because of time
constraints.

Reviewed-by: Dan Bode
2011-07-26 15:45:47 -07:00
Dan Bode
436c925e8a Merge branch 'feature/master/8628_append_line' 2011-07-26 15:35:52 -07:00
Dan Bode
e82370a26d (#8628) Add append_line native type
This commit adds a native type that can check if
a line exists and append it to a file.

This use case seems common enough to warrant its
inclusion into stdlib.

Reviewed-by: Jeff McCune
2011-07-26 15:30:28 -07:00
Jeff McCune
a6ed9fbca3 Update CHANGELOG and version for 0.1.7 2011-06-21 17:08:05 -07:00
Jeff McCune
0ea7a0ffde Update README with getvar() and validate_hash()
The README now provides quick examples of how to take advantage of the
getvar() and validate_hash() functions included in this release of the
stdlib.
2011-06-21 17:06:46 -07:00
Jeff McCune
f036fbbb24 Merge branch 'ticket/master/8010_validate_hash_function'
* ticket/master/8010_validate_hash_function:
  (#8010) Add validate_hash spec tests
  (#8010) Add validate_hash function
2011-06-21 17:03:25 -07:00
Jeff McCune
08882ccd3b (#8010) Add validate_hash spec tests
These tests run through a number of example cases and exercise the
behavior of the validate_hash function.

To run, simple execute rspec validate_hash_spec.rb
2011-06-21 17:02:22 -07:00
Jeff McCune
4c00cfc610 (#8010) Add validate_hash function
This function validates all passed variables are hashes.  This is
similar to the validate_bool function and is copied from it.
2011-06-21 17:01:33 -07:00
Jeff McCune
de2434255e Merge branch 'ticket/master/8010_getvar_function'
* ticket/master/8010_getvar_function:
  (#8010) Add getvar() rvalue function
2011-06-21 17:01:14 -07:00
Jeff McCune
2bca41a9c4 (#8010) Add getvar() rvalue function
This isn't directly related to #8010, but rather indirectly fills the
need to allow the end user to configure where data values are looked up.

This allows the namespace to be passed as a class parameter.  A module
may then quickly and easily look up data from the user-defined
namespace.
2011-06-21 15:12:46 -07:00
Jeff McCune
c642cf4947 Remove metadata.json from repository
This file is generated from the puppet-module build command and should
not be included in the repository.  If it is, the repository is not
directly usable on a Puppet master because the metadata.json is invalid.
2011-06-20 16:05:18 -07:00
Jeff McCune
27973cb594 Update CHANGELOG for version 0.1.6 2011-06-15 11:53:15 -07:00
Jeff McCune
c4e8bb8f97 Merge pull request #4 from jeffmccune/ticket/master/3_anchor_resource_type
Ticket/master/3 anchor resource type

Nan +1'ed on the tech list.

Merging into master.
2011-06-15 11:51:33 -07:00
Jeff McCune
f13f3c2916 (#3) Add simple unit test for anchor type
Unlike the whit type the anchor type derives from, we are not hacking
the stringify method.  We expect the resource to be named simply
Anchor[foo::bar] where the name is "foo::bar".
2011-06-15 09:44:24 -07:00
Jeff McCune
ab70663d15 (#3) Add an anchor type to provide containment
With Puppet 2.6.x we do not have a way to specify containment
relationships.  In the use case of class ntp { } declaring
ntp::{package,config,service} classes, the ntp class itself should allow
the user to specify before and require relationships to the main ntp
class.

The anchor resource type allows module authors to close the loop on
classes composing the main top level module.  For example:

    class ntp {
      class { 'ntp::package': }
      -> class { 'ntp::config': }
      -> class { 'ntp::service': }
      # These two resources "anchor" the composed classes
      # such that the end user may use "require" and "before"
      # relationships with Class['ntp']
      anchor { 'ntp::begin': } -> class { 'ntp::package': }
      class { 'ntp::service': } -> anchor { 'ntp::end': }
    }

Using this pattern, the module user may then simply declare relationships to
the ntp class as they expect:

    class { 'ntp': } -> class { 'mcollective': }
    # OR
    class { 'mcollective': } -> class { 'ntp': }
2011-06-15 09:40:04 -07:00
Jeff McCune
df2398b59c Add additional tests to validate_bool() spec 2011-06-03 11:56:02 -07:00
Jeff McCune
fdb175a6af Update CHANGELOG for 0.1.5 2011-06-03 11:44:37 -07:00
Jeff McCune
593d7f7e76 Add Apache 2.0 License 2011-06-03 11:44:37 -07:00
Jeff McCune
3d093334a6 Merge branch 'feature/master/validation_functions'
* feature/master/validation_functions:
  Add spec test for validate_bool function
  Add validate_bool() function to stdlib
2011-06-03 11:42:39 -07:00
Jeff McCune
20b6c24186 Add spec test for validate_bool function
This is an interesting spec test for module developers.
It illustrates how to cause Puppet to test the function
from the Puppet DSL rather than the Ruby DSL, fully
exercising the system from the perspective of the end
user.

(Note how Puppet[:code] is set, then the scope reset, then
the compile method called.)

Paired-with: Dan Bode <dan@puppetlabs.com>
2011-06-03 11:41:20 -07:00
Jeff McCune
b9f1bb6a63 Add validate_bool() function to stdlib
This function aborts catalog compilation if any of the passed
values are not true or false.  Note, this catches the string
values of true and false correct and will abort catalog
compilation if they are not boolean values.

Paired-with: Dan Bode <dan@puppetlabs.com>
2011-06-03 11:39:45 -07:00
Jeff McCune
cdbdc275ac Update CHANGELOG with stage re-ordering 2011-05-26 10:25:45 -07:00
Jeff McCune
7eacebafeb Merge branch 'bug/master/prefer_stages_after_main'
* bug/master/prefer_stages_after_main:
  Move stages to after main
2011-05-26 10:25:35 -07:00
Jeff McCune
6e9e838a0e Move stages to after main
Working with the stages in stdlib, I quickly ran into an issue where
most of the stages were before the main stage.  This made it difficult
to declare any resources in a traditional "include" style class while
hiding the end user from the stages being associated with other module
classes.

For example, in class mcollective, a package would be declared in main.
However, if mcollective declared class mcollective::service in stage
infra_deploy and this was before main, there would be a dependency loop
between the package and the service.

There appears to be a convention around "chain your stages after main"
to avoid the need to create relatively empty shell classes.
2011-05-26 10:21:42 -07:00
Jeff McCune
46533ae428 Update CHANGELOG for 0.1.3 release 2011-05-25 13:29:27 -07:00
Jeff McCune
5f65682dd2 Merge branch 'feature/master/7657_validate_re'
* feature/master/7657_validate_re:
  (#7657) Add basic validate_re function
2011-05-25 12:39:58 -07:00
Jeff McCune
d381a5b74f (#7657) Add basic validate_re function
While developing Puppet Modules with class parameters, data from the
user should be validated as per the Style Guide.  Puppet should fail
early and hard in the situation of invalid data being passed into the
module.

This function provides a more concise method to the alternative of using
if statements in the Puppet manifests.
2011-05-25 12:38:15 -07:00
Jeff McCune
e757816a95 Add DS_Store to gitignore 2011-05-25 09:36:08 -07:00
Jeff McCune
a78111222e Update changelog for version 0.1.2
Also add release process information.
2011-05-24 11:49:57 -07:00
Jeff McCune
ea972e379d Add changelog to track releases
Following the development process, as new releases of this module are
cut the Changelog will be updated.
2011-05-24 11:27:41 -07:00