Jeff McCune
10575587f4
(maint) Fix location_for helper method
...
Without this patch the location_for helper method in the Gemfile
incorrectly assumes the mdata variable has a value. This patch
addresses the problem by explicitly binding the regular expression match
results to the mdata variable to ensure it has a value when accessed by
index.
2013-08-29 13:02:31 -07:00
Adrien Thebo
6dd6d060df
Merge pull request #172 from ptomulik/fix/delete_xxx_spec
...
small fix to delete_values_spec.rb and README.markdown
2013-08-28 15:39:32 -07:00
Paweł Tomulik
bb9f7d1726
small fix to delete_values_spec.rb and README.markdown
2013-08-14 02:23:36 +02:00
Adrien Thebo
2a78cbfaad
Merge pull request #170 from ptomulik/fix_delete_values
...
minor corrections to delete_values()
2013-08-13 10:27:42 -07:00
Adrien Thebo
66865f2c72
Merge branch 'maint-refactor_validate_slength'
2013-08-12 12:57:55 -07:00
Adrien Thebo
24911db44c
(maint) Validate input argument in a single location
2013-08-12 12:56:00 -07:00
Adrien Thebo
200e585ea7
(maint) refactor validate_slength tests
2013-08-12 12:55:46 -07:00
Adrien Thebo
1950b605fb
(maint) reindent case statement to match standard indentation
2013-08-12 12:55:46 -07:00
Adrien Thebo
b41883933c
(maint) collapse String/Array validation into shared lambda
2013-08-12 12:55:46 -07:00
Adrien Thebo
6df05cbc2d
(maint) clean up validate_slength argument validation
2013-08-12 12:55:46 -07:00
Adrien Thebo
e63715ddaf
(maint) reword error messages for validate_slength
2013-08-12 11:20:46 -07:00
Adrien Thebo
2cfa408909
(maint) Explicitly unpack validate_slength args
2013-08-12 11:13:46 -07:00
Adrien Thebo
4ad1da83f9
(maint) Remove unneeded parens around exceptions
2013-08-12 11:00:27 -07:00
Adrien Thebo
32dbac0049
Merge pull request #169 from hdeheer/patch-1
...
Fix validate_slength, arg.length should be args[0].length
2013-08-12 10:49:47 -07:00
Paweł Tomulik
2ba5404b16
minor corrections to delete_values()
2013-08-08 16:56:32 +02:00
Hubert
77625e6d8f
Fix validate_slength, arg.length should be args[0].length
...
During a puppet run an error will be thrown and a puppet run will fail completely (when using validate_slength):
undefined local variable or method `arg' for #<Puppet::Parser::Scope:0x7f243c236948>
2013-08-08 12:56:12 +02:00
Adrien Thebo
0a02295c42
Merge pull request #167 from mhellmic/minlength
...
extend the validate_slength function to accept a minimum length
2013-08-06 09:48:44 -07:00
Martin Hellmich
0206d367c0
changed the validate_slength function to accept a min length
...
An optional third parameter can be given a min length. The function
then only passes successfully, if all strings are in the range
min_length <= string <= max_length
update and fix function and unit tests
the check for the minlength has to be written differently
because 0 values should be possible. We now check
a) if the input is convertible, and throw a ParseError and
b) if the input .is_a?(Numeric) and ask for a positive number
it's not as clean as for maxlength, but keeps a similar behaviour
refined the error checking for the min length
try to convert to Integer(args[2]) and fail,
if it's not possible
changed the tests accordingly to the new parameter checking
2013-08-06 10:05:16 +02:00
Adrien Thebo
5544be9276
Merge pull request #166 from ptomulik/delete_undef_values
...
Add delete_values() and delete_undef_values() functions
2013-08-05 15:29:08 -07:00
Paweł Tomulik
2069415204
added delete_values() and delete_undef_values() functions
2013-08-05 22:12:26 +02:00
Adrien Thebo
e8dcc69193
Merge branch 'uriescape-use_default_escape_list'
...
This closes GH-164
2013-07-22 13:13:13 -07:00
Tomas Doran
b2e23dc65b
Adjust to use default URI.escape escape list
...
Conform to RFC per comments on: https://github.com/puppetlabs/puppetlabs-stdlib/pull/164
Conflicts:
lib/puppet/parser/functions/uriescape.rb
spec/unit/puppet/parser/functions/uriescape_spec.rb
2013-07-22 13:12:28 -07:00
Adrien Thebo
e0d4588bd2
Merge branch 'pull-163'
...
This closes GH-163
2013-07-11 16:26:45 -07:00
Alex O'Rielly
964a9ad619
( #21416 ) Allow file_line to match multiple lines
...
Without this commit the file_line type will outright fail if multiple
lines match the given regex. This commit allows the file_line type and
provider to optionally match and modify all matching lines.
Changeset rebased into a single commit by Adrien Thebo <adrien@puppetlabs.com>
2013-07-11 16:25:56 -07:00
Adrien Thebo
4d2558f383
Merge pull request #165 from tigercomputing/fixes/ensure_resource-doc
...
ensure_resource: fix documentation typo
2013-06-27 11:19:39 -07:00
Chris Boot
7f98203f18
ensure_resource: fix documentation typo
2013-06-27 17:51:36 +01:00
Adrien Thebo
ca7633c0e4
Merge pull request #158 from wfarr/validate_ip
...
[#20862 ] Add functions to validate ipv4 and ipv6 addresses
2013-06-07 15:06:41 -07:00
Adrien Thebo
928c13139b
Merge branch 'pull-56'
2013-05-28 11:17:29 -07:00
Adrien Thebo
77768e5d8d
(maint) Remove syntax decoration from range_spec
2013-05-28 11:17:00 -07:00
Adrien Thebo
65380bcdfb
(maint) Clean up range_spec error expectation
...
Replace `lambda` with `expect` for making an error expectation
Add an explicit error message in expectation
2013-05-28 11:14:28 -07:00
Adrien Thebo
dd0a4220d5
(maint) Use present tense in range_spec messages
2013-05-28 11:13:20 -07:00
Adrien Thebo
1fcb854f15
(maint) split up range spec with describe blocks
2013-05-28 11:11:50 -07:00
Adrien Thebo
0f2d69fdfd
Merge remote-tracking branch 'pr/56' into pull-56
...
Conflicts:
lib/puppet/parser/functions/range.rb
spec/unit/puppet/parser/functions/range_spec.rb
2013-05-28 11:07:41 -07:00
Adrien Thebo
9c8c8275ab
Merge pull request #159 from fiddyspence/feature/base64
...
Adding base64 function
2013-05-24 09:40:50 -07:00
fiddyspence
3707c47dcd
Adding base64 function
...
Adding base64 function and spec test. Included a bonus fix to
validate_slength_spec.rb to put the expectation message in the right
place.
2013-05-24 16:33:24 +01:00
Will Farrington
e0fd7299f6
Don't run certain tests under 1.8.7
2013-05-22 17:43:37 -07:00
Will Farrington
5d5796a7d5
Update ipv6 examples
2013-05-22 17:37:08 -07:00
Will Farrington
9a41f07e3b
Ruby 2.0 introduces IPAddr::InvalidAddressError
2013-05-22 17:21:38 -07:00
Will Farrington
cf37a128a0
Add functions to validate ipv4 and ipv6 addresses
2013-05-22 17:10:45 -07:00
Hailee Kenney
2cdbbafc06
Merge pull request #157 from rohanrns/master
...
Trivial documentation fix for upcase function.
2013-05-20 09:17:11 -07:00
Rohan Sheth
ad9079e35b
Trivial documentation fix
2013-05-18 11:48:41 -07:00
Hailee Kenney
a2abfb9894
Merge pull request #155 from AlexCline/feature/master/array_comparison_functions
...
(#20684 ) Add array comparison functions, difference, intersection and union
2013-05-15 13:56:15 -07:00
Adrien Thebo
dad3a2948f
Merge pull request #147 from mhellmic/master
...
don't fail on undef variable in merge
2013-05-15 10:58:04 -07:00
Alex Cline
737aa31546
( #20684 ) Add array comparison functions, difference, intersection and union.
...
Included is code, tests and documentation for the difference, intersection
and union functions for comparing arrays.
2013-05-13 12:14:15 -04:00
Jeff McCune
1ffd72daaa
Merge branch 'puppetlabs-release/four_one_oh'
...
* puppetlabs-release/four_one_oh:
Update Modulefile, CHANGELOG for version 4.1.0
closes #154
2013-05-10 14:23:58 -07:00
Ryan Coleman
5c6038458b
Update Modulefile, CHANGELOG for version 4.1.0
...
This commit alters the module metadata to indicate a 4.1.0 version
release for the Puppet Forge. It contains backwards compatible
features, refactors and bug fixes.
CHANGELOG updated by JJM
2013-05-10 14:22:03 -07:00
Martin Hellmich
b975bd66aa
Added rspec tests for the new behaviour of merge accepting empty strings
...
added test that '' is accepted
changed a test that a number is correctly rejected with a type error
2013-05-08 18:24:46 +02:00
Martin Hellmich
f496005bf3
fix in merge.rb: refine the checking if an argument is an empty string
2013-05-08 18:24:07 +02:00
Jeff McCune
226c191e27
Merge branch 'fix_facts_dot_d_with_pe'
...
* fix_facts_dot_d_with_pe:
(maint) Indent facter_dot_d with 2 spaces
(#20582 ) Restore facter_dot_d to stdlib for PE users
Revert "Revert "Revert "Merge branch 'hkenney-ticket/master/2157_remove_facts_dot_d'"""
(maint) Update Gemfile with GEM_FACTER_VERSION
closes #153
2013-05-07 12:10:06 -07:00
Jeff McCune
77ea8439fe
(maint) Indent facter_dot_d with 2 spaces
...
Whitespace only re-flow of facter_dot_d.rb
2013-05-07 09:45:13 -07:00