Commit graph

1392 commits

Author SHA1 Message Date
Alec Henninger
1659d478b9 Add test for basename on path with scheme 2016-01-16 11:55:25 -05:00
David Schmitt
4eba9364f1 Merge pull request #566 from puppetlabs/4.11.x
4.11.0 merge back
2016-01-12 14:41:49 +00:00
David Schmitt
f875770245 Merge pull request #552 from mattbostock/add_x509_rsa_key_pair
Add a function to validate an x509 RSA key pair
2016-01-08 11:13:16 +00:00
Matt Bostock
41f9319bbd Change order of tests to be more logical
Put the tests using a valid certificate fixture together and put tests
using a valid key fixture together.
2016-01-08 11:09:45 +00:00
Matt Bostock
4acba73b00 Test certificate and key with a truncated middle
Test a valid certificate and valid key that have had 48 characters
removed from their middle, to simulate a malformed certificate and key.

Suggested by @DavidS in https://github.com/puppetlabs/puppetlabs-stdlib/pull/552
2016-01-08 11:09:45 +00:00
Matt Bostock
97320ab421 Add a function to validate an x509 RSA key pair
Add a function to validate an x509 RSA certificate and key pair, as
commonly used for TLS certificates.

The rationale behind this is that we store our TLS certificates and
private keys in Hiera YAML files, and poor indentation or formatting in
the YAML file could cause a valid certificate to be considered invalid.

Will cause the Puppet run to fail if:

- an invalid certificate is detected
- an invalid RSA key is detected
- the certificate does not match the key, i.e. the certificate
  has not been signed by the supplied key

The test certificates I've used in the spec tests were generated using
the Go standard library:

    $ go run $GOROOT/src/crypto/tls/generate_cert.go -host localhost

Example output:

    ==> cache-1.router: Error: Not a valid RSA key: Neither PUB key nor PRIV key:: nested asn1 error at /var/govuk/puppet/modules/nginx/manifests/config/ssl.pp:30 on node cache-1.router.dev.gov.uk
2016-01-08 11:09:45 +00:00
David Schmitt
fdf3f22e24 Merge pull request #565 from tphoney/4.11.0_tweak
minor tweak to 4.11.0 adding debian 8 to metadata
2016-01-07 11:15:39 +00:00
tphoney
33b79f3497 minor tweak to 4.11.0 adding debian 8 to metadata 2016-01-07 10:54:48 +00:00
David Schmitt
9cce93054a Merge pull request #545 from mpolenchuk/master
Add clamp function
2016-01-04 15:35:42 +00:00
Jesse Lovelace
39644a69af Merge pull request #564 from tphoney/4.11.0_prep
4.11.0 prep
2015-12-31 11:34:44 -05:00
Michael Polenchuk
27782242bc Add clamp function
Clamp keeps value within the range.
Employ of soft() makes the whole thing is independant of order.
2015-12-31 12:46:07 +03:00
tphoney
00973036b2 4.11.0 prep 2015-12-30 13:45:05 +00:00
Bryan Jen
0073c6d8de Merge pull request #553 from logicminds/absolute_path
adds new parser called is_absolute_path
2015-12-21 17:41:55 -07:00
TP Honey
1c6ae4793f Merge pull request #561 from DavidS/fix-package_provider
Allow package_provider fact to resolve on PE 3.x
2015-12-21 16:54:20 +00:00
David Schmitt
35b5d6bcc1 Allow package_provider fact to resolve on PE 3.x
PE 3.x emits a puppetversion fact in the format "3.x.x (Puppet Enterprise 3.x.x)". This fact causes an error when invoked on PE 3.x: Could not retrieve fact='package_provider', resolution='<anonymous>': Malformed version number string 3.8.1 (Puppet Enterprise 3.8.1

This fix has been tested on PE 3.8.2 and should work for PE 3.3, 3.7, and 3.8.

Original-fix-by: Alex Harden <aharden@gmail.com>
2015-12-18 17:38:04 +00:00
TP Honey
8ea26c4c45 Merge pull request #559 from DavidS/fm-3802-fix-ensure_resource-test
(FM-3802) make ensure_resource test of packages
2015-12-17 13:59:52 +00:00
David Schmitt
02965b89e5 (FM-3802) make ensure_resource test of packages
This ensures that the test passes independently of changes to rubygems.
2015-12-17 13:50:15 +00:00
Corey Osman
1da820e61e refactors the validate_absolute_path to utilize the is_absolute_path 2015-12-15 23:24:17 -08:00
Corey Osman
1b048ff9d6 adds new parser called is_absolute_path
* is_absolute_path returns boolean true if the given path
    is absolute, returns false otherwise.
  * works for windows and unix
2015-12-15 23:24:17 -08:00
Jesse Lovelace
d2ae00cd5f Merge pull request #558 from puppetlabs/4.10.x
4.10.x mergeback
2015-12-15 14:53:01 -06:00
Bryan Jen
0b4822be3d Merge pull request #557 from jbondpdx/4.10.x
edits to README
2015-12-14 15:06:08 -07:00
jbondpdx
8fcefcfdb1 more carriage returns 2015-12-14 13:35:23 -08:00
jbondpdx
802e3adf16 more carriage returns, no 2015-12-14 11:57:01 -08:00
jbondpdx
d00bccc96f removing mid-line carriage returns 2015-12-14 11:50:51 -08:00
jbondpdx
4abc6e6e3b edits to README 2015-12-14 11:19:53 -08:00
Bryan Jen
9a1d8be10d Merge pull request #556 from HelenCampbell/4.10.0_prep
Changelog and versionbump for 4.10.0
2015-12-11 13:26:46 -07:00
Helen Campbell
964e24a637 Changelog and versionbump for 4.10.0 2015-12-11 20:08:25 +00:00
Bryan Jen
93600e45b0 Merge pull request #554 from kjetilho/ticket/2886-seeded_rand
(#2886) seeded_rand: new function
2015-12-10 11:54:10 -07:00
TP Honey
7a745deec6 Merge pull request #555 from puppetlabs/4.9.x
4.9.x Mergeback
2015-12-08 15:47:14 +00:00
Kjetil Torgrim Homme
8aecd63378 (#2886) seeded_rand: new function
seeded_rand is needed for repeatable randomness across nodes in a cluster
2015-12-08 14:59:12 +01:00
Bryan Jen
88a9a314c3 Merge pull request #546 from jdevesa/validate_ip
Add validator for any IP address
2015-11-30 11:10:57 -07:00
Jaume Devesa
fe23e01a4b Add validator for any IP address
Provide a validator for IP addresses, regardless they are IPv4 or IPv6,
and its documentation.
2015-11-30 17:34:00 +01:00
Bryan Jen
f684fb817c Merge pull request #550 from tphoney/release_4.9.1
4.9.1 release prep
2015-11-24 18:06:43 -07:00
tphoney
01c42d5212 4.9.1 release prep 2015-11-24 15:33:02 +00:00
David Schmitt
06b2cfbf73 Merge pull request #551 from mattbostock/fix_ipv4_doc
Fix reference to validate_bool in IP4 function
2015-11-24 10:41:30 +00:00
Matt Bostock
7b068781a5 Fix reference to validate_bool in IP4 function
The documentation in `validate_ipv4_address` references `validate_bool`,
but I believe this should read `validate_ipv4_address` instead, which
makes more sense.
2015-11-23 23:45:55 +00:00
Hunter Haugen
ef0c13b1af Merge pull request #548 from bmjen/ruby187
Fix Gemfile to work with ruby 1.8.7
2015-11-20 12:44:27 -08:00
Bryan Jen
c43924682a Fix Gemfile to work with ruby 1.8.7 2015-11-20 12:14:30 -07:00
Bryan Jen
0d2020001d Merge pull request #543 from ghoneycutt/patch-2
Use absolute class name in example
2015-11-20 09:09:52 -07:00
Bryan Jen
13e307b2c6 Merge pull request #547 from reidmv/fm_3773
(FM-3773) Fix root_home fact on AIX 5.x
2015-11-20 09:07:56 -07:00
Reid Vandewiele
13e5d467c9 (FM-3773) Fix root_home fact on AIX 5.x
The -C (capital C) flag to lsuser is incorrect. It should be -c
(lowercase).

this commit updates the aix root_home fact to use `lsuser -c`, rather
than `lsuser -C`.
2015-11-19 15:44:52 -08:00
David Schmitt
61333cfc48 Merge pull request #544 from HelenCampbell/readmeaddition
pick_default addition to readme
2015-11-09 15:17:01 +00:00
Helen Campbell
99db982741 pick_default addition to readme 2015-11-09 15:14:34 +00:00
Garrett Honeycutt
dc9b81d87e Use absolute class name in example 2015-11-06 12:19:21 -05:00
Helen
5d8a5ac631 Merge pull request #542 from greg0ire/patch-1
use properly encoded characters
2015-11-06 16:45:29 +00:00
Grégoire Paris
7fdc312348 use properly encoded characters
This is more severe than it sounds. These characters make puppet fail with the following message : 

> Error 400 on SERVER: "\xC3" on US-ASCII
2015-11-03 17:04:10 +01:00
David Schmitt
45ec648cdf Merge pull request #541 from mattflaschen/patch-1
Fix capitalize docs
2015-10-28 10:15:08 +00:00
Matt Flaschen
1421aa4a87 Fix capitalize docs
Capitalize lower-cases the remaining characters (due to the Ruby function having this behavior); document this, and make minor wording tweaks.
2015-10-27 18:09:18 -04:00
David Schmitt
143d4aa7be Merge pull request #540 from marrero984/update_str2bool_readme
(#2183) updated str2bool readme wording
2015-10-23 09:51:56 +01:00
marrero984
2c3c6fde98 (#2183) updated str2bool readme wording 2015-10-22 14:02:13 -07:00