Commit graph

15 commits

Author SHA1 Message Date
Jeff McCune
3d093334a6 Merge branch 'feature/master/validation_functions'
* feature/master/validation_functions:
  Add spec test for validate_bool function
  Add validate_bool() function to stdlib
2011-06-03 11:42:39 -07:00
Jeff McCune
20b6c24186 Add spec test for validate_bool function
This is an interesting spec test for module developers.
It illustrates how to cause Puppet to test the function
from the Puppet DSL rather than the Ruby DSL, fully
exercising the system from the perspective of the end
user.

(Note how Puppet[:code] is set, then the scope reset, then
the compile method called.)

Paired-with: Dan Bode <dan@puppetlabs.com>
2011-06-03 11:41:20 -07:00
Jeff McCune
b9f1bb6a63 Add validate_bool() function to stdlib
This function aborts catalog compilation if any of the passed
values are not true or false.  Note, this catches the string
values of true and false correct and will abort catalog
compilation if they are not boolean values.

Paired-with: Dan Bode <dan@puppetlabs.com>
2011-06-03 11:39:45 -07:00
Jeff McCune
cdbdc275ac Update CHANGELOG with stage re-ordering 2011-05-26 10:25:45 -07:00
Jeff McCune
7eacebafeb Merge branch 'bug/master/prefer_stages_after_main'
* bug/master/prefer_stages_after_main:
  Move stages to after main
2011-05-26 10:25:35 -07:00
Jeff McCune
6e9e838a0e Move stages to after main
Working with the stages in stdlib, I quickly ran into an issue where
most of the stages were before the main stage.  This made it difficult
to declare any resources in a traditional "include" style class while
hiding the end user from the stages being associated with other module
classes.

For example, in class mcollective, a package would be declared in main.
However, if mcollective declared class mcollective::service in stage
infra_deploy and this was before main, there would be a dependency loop
between the package and the service.

There appears to be a convention around "chain your stages after main"
to avoid the need to create relatively empty shell classes.
2011-05-26 10:21:42 -07:00
Jeff McCune
46533ae428 Update CHANGELOG for 0.1.3 release 2011-05-25 13:29:27 -07:00
Jeff McCune
5f65682dd2 Merge branch 'feature/master/7657_validate_re'
* feature/master/7657_validate_re:
  (#7657) Add basic validate_re function
2011-05-25 12:39:58 -07:00
Jeff McCune
d381a5b74f (#7657) Add basic validate_re function
While developing Puppet Modules with class parameters, data from the
user should be validated as per the Style Guide.  Puppet should fail
early and hard in the situation of invalid data being passed into the
module.

This function provides a more concise method to the alternative of using
if statements in the Puppet manifests.
2011-05-25 12:38:15 -07:00
Jeff McCune
e757816a95 Add DS_Store to gitignore 2011-05-25 09:36:08 -07:00
Jeff McCune
a78111222e Update changelog for version 0.1.2
Also add release process information.
2011-05-24 11:49:57 -07:00
Jeff McCune
ea972e379d Add changelog to track releases
Following the development process, as new releases of this module are
cut the Changelog will be updated.
2011-05-24 11:27:41 -07:00
Jeff McCune
6f8b78cc67 Add standard set of run stages.
Many modules I'm working on need a standard but
relatively granular location in the catalog.  For example,
any module that configures the packaging system should
run "early"

Add the following stages which have inter-dependencies
in the top to bottom order listed:

 * setup
 * deploy
 * runtime
 * setup_infra
 * deploy_infra
 * main
 * setup_app
 * deploy_app
2011-05-24 11:25:51 -07:00
Jeff McCune
6964d13b26 Update README with target versions
Also add the list of things this module will
likely contain.
2011-05-24 11:23:16 -07:00
Jeff McCune
6e9d0465bc Initial commit 2011-05-24 11:06:30 -07:00