Commit graph

1345 commits

Author SHA1 Message Date
David Schmitt
45ec648cdf Merge pull request #541 from mattflaschen/patch-1
Fix capitalize docs
2015-10-28 10:15:08 +00:00
Matt Flaschen
1421aa4a87 Fix capitalize docs
Capitalize lower-cases the remaining characters (due to the Ruby function having this behavior); document this, and make minor wording tweaks.
2015-10-27 18:09:18 -04:00
David Schmitt
143d4aa7be Merge pull request #540 from marrero984/update_str2bool_readme
(#2183) updated str2bool readme wording
2015-10-23 09:51:56 +01:00
marrero984
2c3c6fde98 (#2183) updated str2bool readme wording 2015-10-22 14:02:13 -07:00
David Schmitt
2db7440c67 Merge pull request #538 from mmckinst/bool2str_enhance
add functionality to bool2str function
2015-10-16 09:31:01 +01:00
Mark McKinstry
6de1a6e062 add functionality to bool2str to return strings of your choice for a boolean 2015-10-15 22:22:10 -04:00
Hunter Haugen
39126a7bc8 Merge pull request #539 from mentat/MODULES-2696
Add check to ensure regex does not throw for none type.
2015-10-15 10:23:02 -07:00
Jesse Lovelace
6aa7f2db99 Add check to ensure regex does not throw for none type.
Add a quick check to ensure puppetversion value is not nil and supporting test.
2015-10-15 11:27:03 -05:00
David Schmitt
57a8485223 Merge pull request #537 from cmurphy/fix_load_module_metadata
Fix load module metadata
2015-10-15 09:44:12 +01:00
Colleen Murphy
25410c4598 Let load_module_metadata succeed on empty file
Some modules or module versions don't have a metadata.json file, but we
might still want to use the load_module_metadata function on them. The
lack of a file can still give us important information. For example, it
might tell us that the version of the module installed is "very old"
even if we can't read the version number directly. This patch adds a
parameter to let the user specify if an empty file is acceptable. To
preserve backwards compatibility it does not change the current default
behavior, which is to raise an error if metadata.json does not exist.
2015-10-14 16:16:01 -07:00
Colleen Murphy
0f8df10084 Rename load_module_metadata test path
`rake spec` only finds test files that end in _spec.rb, so this test
was not being run. Correct the path name so that the test runs
properly.
2015-10-14 15:59:09 -07:00
TP Honey
5b3c623394 Merge pull request #536 from DavidS/improve-file_line-docs
(MODULES-2421) improve description of file_line
2015-10-14 12:46:19 +01:00
David Schmitt
ad173f2d05 (MODULES-2421) improve description of file_line
This mostly needed extraction of the existing doc strings from
the type.
2015-10-13 15:03:26 +01:00
David Schmitt
4e62223801 Merge pull request #535 from martinpfeifer/package_provider_fact
prevent deprecation warning about the allow_virtual parameter
2015-10-13 10:18:59 +01:00
Martin Pfeifer
d73fd3c5ef prevent deprecation warning about the allow_virtual parameter 2015-10-13 10:08:01 +02:00
Bryan Jen
e1a9bf5063 Merge pull request #534 from asasfu/feature/package_provider_fact
Add package_provider fact
2015-10-01 10:27:51 -07:00
David Schmitt
76db98120a Merge pull request #533 from HelenCampbell/MODULES-2614-Improved
Modules 2614 improved numeric value handling on empty function
2015-09-28 17:11:10 +01:00
Helen Campbell
c7c4d41a82 Added acceptance test and updated readme 2015-09-28 16:18:56 +01:00
Roman Mueller
6f1d164da6 Check for numeric values as empty fails on those 2015-09-28 16:01:11 +01:00
Helen
48b658fc1c Merge pull request #532 from DavidS/fix-is_a-readme
(FM-3701) Update README for is_a
2015-09-28 11:16:28 +01:00
David Schmitt
bfa21edbae (FM-3701) Update README for is_a 2015-09-28 11:12:25 +01:00
David Schmitt
39e81aa8b5 Merge pull request #531 from asasfu/improvement/service_provider_fact
fixup-PR#506 Speed improvements in facter resolution
2015-09-28 10:09:17 +01:00
Adam S
440245d40d fixup-PR#506 Speed improvements in facter resolution
This is to improve speed on Facter resolution of service_provider fact
that was just introduced in PR# 506.  The improvements go from 280ms
resolution time approx. down to 2ms resolution time approx. by adding
requires statements.
2015-09-25 18:06:00 -07:00
Adam S
ce6e8679b6 Add package_provider fact
This adds a package_provider fact for situations where we need to be
able to know the client's package provider in a simple way.  Situations
such as: package { 'name': install_options => [] }  As those tend to be
package provider specific options.
2015-09-25 17:55:21 -07:00
Hunter Haugen
4d1bca3359 Merge pull request #506 from binford2k/feature/service_provider_fact
Add a service_provider fact
2015-09-24 10:55:39 -07:00
David Schmitt
6bb1c27b99 Merge pull request #530 from HelenCampbell/MODULES-2614
Adding update to empty function readme
2015-09-23 11:38:53 +01:00
Helen Campbell
92b068ad20 Adding update to empty function readme 2015-09-23 11:27:48 +01:00
Bryan Jen
cebb9f333f Merge pull request #528 from mhaskel/is_a_fixes
Update is_a acceptance tests to only run on puppet4
2015-09-21 16:33:22 -07:00
Morgan Haskel
b20239e796 Update is_a acceptance tests to only run on puppet4 2015-09-21 14:12:25 -07:00
Bryan Jen
97bd656efb Merge pull request #527 from mhaskel/511_compatibility
Fix backwards compatibility from #511
2015-09-21 11:20:35 -07:00
Morgan Haskel
799c38e14e Fix backwards compatibility from #511
Maintain the old behavior in the case where the optional second
parameter isn't passed. Also, adding arity is backwards incompatible since
stdlib still supports 2.7, so remove that.
2015-09-21 11:11:21 -07:00
Hunter Haugen
9b1932c538 Merge pull request #526 from DavidS/improve-validate_re-docs
(MAINT) validate_re: Clarify docs and error message
2015-09-17 12:12:12 -07:00
David Schmitt
55ece7815a (MAINT) validate_re: Clarify docs and error message 2015-09-17 18:48:32 +01:00
David Schmitt
399ce03f68 Merge pull request #524 from binford2k/docs/intersection_truthiness
Clarify what an empty intersection looks like.
2015-09-14 19:36:56 +01:00
Ben Ford
169f8af506 Clarify what an empty intersection looks like. 2015-09-14 11:25:38 -07:00
Bryan Jen
0ea0e40228 Merge pull request #523 from DavidS/modules-2516-is_a
(MODULES-2561) add is_a function
2015-09-14 10:49:50 -07:00
Bryan Jen
c0df8192ee Merge pull request #511 from dmitryilyin/parseyaml_default
[MODULES-2462] Improve parseyaml function
2015-09-14 10:40:35 -07:00
David Schmitt
00c881d0da (MODULES-2516) Adds an is_a() function
The data type system is very hard to understand. Many people don't
understand why

    type_of([1,2,3]) == Array

will fail, but

    type_of([1,2,3]) <= Array

passes. This does a simpler validation that doesn't rely on explicit
data types. Instead, use

    $foo = [1,2,3]
    if $foo.is_a(Array) {
      notify { 'This is an array': }
    }

This is based on code by Ben Ford <ben.ford@puppetlabs.com>.

  * Added acceptance tests
  * Added dispatch
  * Improved unit tests
  * Added docs to README
2015-09-14 18:26:25 +01:00
TP Honey
2a7a93ffb4 Merge pull request #518 from logicminds/case_insensitive
accept any case of boolean strings
2015-09-09 11:20:18 +01:00
TP Honey
00b11c20c8 Merge pull request #519 from dmitryilyin/fetch
[MAINT] Improve 'try_get_value' readme
2015-09-08 11:15:45 +01:00
Dmitry Ilyin
411978db32 [MAINT] Improve 'try_get_value' readme 2015-09-04 19:24:15 +03:00
Corey Osman
f2f2db4795 accept any case of boolean strings
* previously the str2bool function did not accept 'TRUE' as a bool
    type.  This causes the function to now accept TRUE, FALSE strings
    as a boolean type in order to be converted to a proper boolean.
  * This would also cause Y,N, YES, NO to be accepted as boolean types
    as well.
2015-09-04 08:09:26 -07:00
TP Honey
6a1afae97e Merge pull request #517 from DavidS/try_get_value-acceptance
(MAINT) fix up try_get_value acceptance test
2015-09-02 13:42:11 +01:00
David Schmitt
5ef5c6629f (MAINT) fix up try_get_value acceptance test 2015-09-02 13:34:15 +01:00
David Schmitt
64267eb650 Merge pull request #513 from dmitryilyin/fetch
Add a new function "try_get_value"
2015-09-02 09:23:46 +01:00
Dmitry Ilyin
823a352f0f Add a new function "try_get_value"
* Extracts a value from a deeply-nested data structure
* Returns default if a value could not be extracted
2015-09-01 21:45:44 +03:00
David Schmitt
9352db77a6 Merge pull request #515 from jfautley/ticket/MODULES-2478-support_root_home_fact_on_AIX
(MODULES-2478) Make root_home fact work on AIX using native lsuser command
2015-09-01 08:31:31 +01:00
Jon Fautley
6c2a003f21 (MODULES-2478) Support root_home fact on AIX through "lsuser" command
Squashed, and amended test for comment lines.
2015-08-28 15:21:13 +01:00
TP Honey
b10978703a Merge pull request #514 from DavidS/add-convert_base
Adds a convert_base function, which can convert numbers between bases
2015-08-27 10:50:29 +01:00
fhats
2d4f5aa4d9 Adds a convert_base function, which can convert numbers between bases
Squashed, improved docs, updated error handling and unit tests by David S.
2015-08-27 10:42:13 +01:00