opuppet/puppetlabs-stdlib
4
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
1234 commits 2 branches 0 tags 1.8 MiB
Commit graph

1234 commits

This branch
This branch
All branches
Author SHA1 Message Date
David Schmitt
c9e093f8d3 (maint) getvar: update spec to match implementation 2015-06-12 14:42:09 +01:00
David Schmitt
8267dbc149 Merge pull request #470 from Yelp/getvar_future_parser 
Also catch :undefined_variable as thrown by future parser
 2015-06-11 18:23:29 +01:00
David Schmitt
0191a3fb77 Merge pull request #472 from justinstoller/maint/master/set_puppet_version 
(maint) update PUPPET_VERSION default to be 3.8.1
 2015-06-09 15:49:14 +01:00
Justin Stoller
a41cfbd043 (maint) update PUPPET_VERSION default to be 3.8.1 2015-06-08 21:43:36 -07:00
TP Honey
237c4b5149 Merge pull request #471 from puppetlabs/travisci_update 
Updated travisci file to remove allow_failures on Puppet4
 2015-06-05 13:35:00 +01:00
Tomas Doran
212c498df3 Also catch :undefined_variable as thrown by future parser 2015-06-05 12:43:01 +01:00
Morgan Haskel
c69b75f88b Merge pull request #469 from hunner/fix_time 
Fix time() on 1.8.7
 2015-06-04 10:51:41 -07:00
Hunter Haugen
ad4ca4cc34 Fix time() on 1.8.7 
The time() function takes an argument of a timezone, and always returns
time in epoch format. The epoch format is the number of seconds that
have elapsed since January 1, 1970 (midnight UTC/GMT), not counting leap
seconds. This means that it is universally the same regardless of
timezones.

I don't know what the timezone argument is supposed to do, and it is not
documented. So lets just make 1.8.7 work like > 1.8.7
 2015-06-04 09:40:52 -07:00
Jonathan Tripathy
650216e533 Updated travisci file to remove allow_failures on Puppet4 2015-06-04 14:21:00 +01:00
David Schmitt
0dd4f69424 Merge pull request #468 from kylog/camels-all-the-way-down 
Fix spelling of camelcase
 2015-06-03 18:22:51 +01:00
David Schmitt
09b427b426 Merge pull request #466 from elyscape/fix/improve_fqdn_acceptance_tests 
Improve fqdn_rotate/fqdn_rand_string acceptance tests
 2015-06-03 18:19:38 +01:00
Kylo Ginsberg
84f49d3a1c (doc) Fix spelling of camelcase in CHANGELOG.md 2015-06-02 15:33:37 -07:00
Eli Young
98c2f283b0 fqdn_rand_string: Add acceptance tests for custom charsets 2015-06-02 12:02:30 -07:00
Eli Young
84279e90ab fqdn_rotate: Add acceptance tests for custom seeds 2015-06-02 12:02:30 -07:00
TP Honey
f5f72f4b5a Merge pull request #467 from DavidS/document-rspec-puppet-version-reqs 
Gemfile: specify minimum rspec-puppet version
 2015-06-02 12:23:39 +01:00
David Schmitt
1d6da9674e Gemfile: specify minimum rspec-puppet version 
Only 2.2 contains all the features we're currently using. Documenting
that in the Gemfile should make that clear.
 2015-06-02 12:21:25 +01:00
David Schmitt
07e8b39615 Merge pull request #462 from elyscape/fix/fqdn_rotate_seeds_with_argument 
fqdn_rotate: Don't use the value itself as part of the random seed
 2015-06-02 12:05:19 +01:00
Eli Young
b436216fe6 fqdn_rotate: Add tests for custom seeds 2015-06-01 17:03:42 -07:00
Eli Young
d7c8460353 fqdn_rotate: Improve documentation 2015-06-01 16:19:07 -07:00
Eli Young
601f681787 fqdn_rotate: Don't use the value itself as part of the random seed 
Previously, the random number generator was seeded with the array or
string to be rotated in addition to any values specifically provided for
seeding. This behavior is potentially insecure in that it allows an
attacker who can modify the source data to choose the post-shuffle
order.
 2015-06-01 16:19:07 -07:00
Hunter Haugen
a383705fdb Merge pull request #464 from DavidS/modules-1882-convert-to-rspec 
(MODULES-1882) convert function tests to rspec-puppet
 2015-06-01 13:36:25 -07:00
David Schmitt
18d4c21418 Remove unused puppet_spec code 
This is copied and changed code from an older version of puppet's internal
test setup code. It does not work with puppet4.
 2015-06-01 18:02:22 +01:00
David Schmitt
f3e79ddcd5 Convert tests to use plain rspec-puppet 
Tests in the new style produces the following documentation output:

abs
  should not eq nil
  should run abs() and raise an Puppet::ParseError
  should run abs(-34) and return 34
  should run abs("-34") and return 34
  should run abs(34) and return 34
  should run abs("34") and return 34
 2015-06-01 18:02:22 +01:00
David Schmitt
b62dff0c6e spec_helper: implement an easy way for specs to confine to puppet version 
Usage:

    describe 'puppet3 behaviour', :unless => RSpec.configuration.puppet_future do
    describe 'puppet4 behaviour', :if => RSpec.configuration.puppet_future do
 2015-06-01 12:21:59 +01:00
David Schmitt
78bd9c8cbe Add the missing symlinks to get puppet 4 pickup the functions from the environmentpath 2015-06-01 12:21:59 +01:00
David Schmitt
1fcce9082f root all the gitignore patterns to avoid unintentional matches 2015-06-01 12:21:59 +01:00
David Schmitt
ad7d12e460 Remove duplicate rake task and enable metadata.json linting 
The :validate task is already provided by
puppetlabs_spec_helper/rake_tasks and would check files twice.

The metadata.json linting is just good form.
 2015-06-01 12:21:59 +01:00
David Schmitt
65b56c711d Workaround the broken rspec-mocks support in rspec-puppet 2015-06-01 12:21:59 +01:00
David Schmitt
080d1637f0 Enable bundler caching on travis 2015-06-01 12:21:58 +01:00
David Schmitt
1ae9058518 Merge pull request #465 from igalic/patch-1 
simplify mac address regex
 2015-05-30 14:33:27 +01:00
Igor Galić
687600c30c simplify mac address regex 
let the computer do the counting and repetition and case
 2015-05-29 20:13:21 +02:00
David Schmitt
4a8c0a57f2 Merge pull request #463 from CENGN/fix/master/file_line_multiple_after 
(MODULES-2071) Patch file_line provider to use multiple with after
 2015-05-29 10:21:41 +01:00
Raymond Maika
72089f3d13 (MODULES-2071) Refactor file_line provider to contain logic to handle parameter multiple in function handle_create_with_after 
Without this, file_line resource without the `match` parameter but with the `after` param will throw an error if there are multiple matches for the after expression. This patch creates the handling for the `multiple` parameter in handle_create_with_after. This allows you to add a line after the `after` expression if it appears at multiple points in a file.

Updated reference to `file_line` in the README to reflect that the multiple parameter can be set when using `after` and/or `match` as the matching regex.
 2015-05-29 00:30:44 -04:00
TP Honey
c9b810cf36 Merge pull request #461 from DavidS/validate-hashes 
validate_integer, validate_numeric: explicitely reject hashes in arrays
 2015-05-28 13:29:43 +01:00
David Schmitt
cf9f7a6b7e validate_integer, validate_numeric: explicitely reject hashes in arrays 
Without this patch, Ruby 1.8's Hash#to_s behaviour causes [{1=>2}] to be
treated as "12" when validating values.
 2015-05-27 20:05:05 +01:00
Hunter Haugen
b4090184c7 Add ability to unittest puppet 4 2015-05-27 08:14:19 -07:00
TP Honey
3fafad88b3 Merge pull request #460 from DavidS/fix-fqdn_rotate-seed 
fqdn_rotate: reset srand seed correctly on old ruby versions
 2015-05-26 15:48:22 +01:00
David Schmitt
0dc0e0dbcf fqdn_rotate: reset srand seed correctly on old ruby versions 
Without this, the global seed is reseeded on every use
of fqdn_rotate, which is a waste. Older rubies might even use a
time-base seed which adversly impacts the quality of the RNG.
 2015-05-26 14:25:43 +01:00
Bryan Jen
6cf64f1028 Merge pull request #454 from elyscape/document_facts.d_cache 
(FM-2130) Document new location of facts.d cache
 2015-05-21 10:42:32 -07:00
Morgan Haskel
06ebdf3ef7 Merge pull request #455 from hunner/change_type_of_test 
Remove all the pops stuff
 2015-05-21 10:41:41 -07:00
Morgan Haskel
1401e267b3 Merge pull request #458 from ghoneycutt/patch-1 
Update CHANGELOG.md
 2015-05-21 10:20:40 -07:00
Garrett Honeycutt
48e516be6b Update CHANGELOG.md 2015-05-20 15:16:45 -04:00
Bryan Jen
97ee232ed0 Merge pull request #456 from jtappa/readme-edits 
DOC-1504: Readme edits
 2015-05-14 15:08:52 -07:00
Jorie Tappa
593f74ced7 DOC-1504: README edits 2015-05-14 15:03:23 -07:00
Hunter Haugen
732f7e8b35 Remove all the pops stuff 
The rspec-puppet matchers don't allow to check the return types, but
this is a pretty rare thing to need to do anyway, so probably not worth
patching rspec-puppet
 2015-05-12 15:03:27 -07:00
Eli Young
3b8ded184d (FM-2130) Document new location of facts.d cache 2015-05-11 11:12:15 -07:00
David Schmitt
35c77c7a7a Merge pull request #449 from puppetlabs/modulesync_updates 
sync via modulesync
 2015-05-07 11:03:39 +01:00
Morgan Haskel
ecd4f3e4dc sync via modulesync 2015-05-06 14:10:40 -07:00
TP Honey
4f6c6fa3e5 Merge pull request #448 from DavidS/fix_range 
range(): fix TypeError(can't convert nil into Integer) when using range ...
 2015-05-06 13:55:22 +01:00
David Schmitt
f49eb6b8e2 range(): fix TypeError(can't convert nil into Integer) when using range syntax 2015-05-06 10:13:27 +01:00